Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/log: TestCrashReportingPacket fails on go1.12 #35792

Closed
petermattis opened this issue Mar 15, 2019 · 1 comment
Closed

util/log: TestCrashReportingPacket fails on go1.12 #35792

petermattis opened this issue Mar 15, 2019 · 1 comment
Assignees
@ajwerner
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@petermattis
Copy link
Collaborator

The expected line numbers are off by one:

--- FAIL: TestCrashReportingPacket (0.20s)
    --- FAIL: TestCrashReportingPacket/#00 (0.00s)
        crash_reporting_packet_test.go:154: expected crash_reporting_packet_test.go:83: boom, got crash_reporting_packet_test.go:84: boom
    --- FAIL: TestCrashReportingPacket/#01 (0.00s)
        crash_reporting_packet_test.go:154: expected crash_reporting_packet_test.go:91: baam, got crash_reporting_packet_test.go:92: baam
@petermattis petermattis added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-logging In and around the logging infrastructure. labels Mar 15, 2019
@petermattis petermattis self-assigned this Mar 15, 2019
@knz knz mentioned this issue Mar 17, 2019
Closed
5 tasks
@bdarnell bdarnell mentioned this issue Mar 17, 2019
Closed
@ajwerner ajwerner assigned ajwerner and unassigned petermattis Mar 25, 2019
ajwerner added a commit to ajwerner/cockroach that referenced this issue Mar 26, 2019
@ajwerner
log: fix call depth for go1.12 panics
50140b0 
This PR fixes the following test failure on Linux:

```
$ make test IGNORE_GOVERS=1 PKG=./pkg/util/log
--- FAIL: TestCrashReportingPacket (0.20s)
    --- FAIL: TestCrashReportingPacket/#00 (0.00s)
        crash_reporting_packet_test.go:155: expected crash_reporting_packet_test.go:85: boom, got testing.go:865: boom
    --- FAIL: TestCrashReportingPacket/#1 (0.00s)
        crash_reporting_packet_test.go:155: expected crash_reporting_packet_test.go:93: baam, got testing.go:865: baam
FAIL
```

Interestingly this is not quite the same failure noted in cockroachdb#35792, maybe that's
MacOS specific?

Release note: None
@ajwerner ajwerner mentioned this issue Mar 26, 2019
Merged
ajwerner added a commit to ajwerner/cockroach that referenced this issue Mar 26, 2019
@ajwerner
log: fix call depth for go1.12 panics
84bd549 
This PR fixes the following test failure on Linux:

```
$ make test IGNORE_GOVERS=1 PKG=./pkg/util/log
--- FAIL: TestCrashReportingPacket (0.20s)
    --- FAIL: TestCrashReportingPacket/#00 (0.00s)
        crash_reporting_packet_test.go:155: expected crash_reporting_packet_test.go:85: boom, got testing.go:865: boom
    --- FAIL: TestCrashReportingPacket/#1 (0.00s)
        crash_reporting_packet_test.go:155: expected crash_reporting_packet_test.go:93: baam, got testing.go:865: baam
FAIL
```

Interestingly this is not quite the same failure noted in cockroachdb#35792, maybe that's
MacOS specific?

Release note: None
craig bot pushed a commit that referenced this issue Mar 26, 2019
@ajwerner
Merge #36144
f10f6db 
36144: log: fix call depth for go1.12 panics r=ajwerner a=ajwerner

This PR fixes the following test failure on Linux:

```
$ make test IGNORE_GOVERS=1 PKG=./pkg/util/log
--- FAIL: TestCrashReportingPacket (0.20s)
    --- FAIL: TestCrashReportingPacket/#00 (0.00s)
        crash_reporting_packet_test.go:155: expected crash_reporting_packet_test.go:85: boom, got testing.go:865: boom
    --- FAIL: TestCrashReportingPacket/#1 (0.00s)
        crash_reporting_packet_test.go:155: expected crash_reporting_packet_test.go:93: baam, got testing.go:865: baam
FAIL
```

Interestingly this is not quite the same failure noted in #35792, maybe that's
MacOS specific?

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
@ajwerner
Copy link
Contributor

ajwerner commented Apr 8, 2019

@dt reports this now also passes on the Mac so must have been related to the call depth problem.

@ajwerner ajwerner closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajwerner @petermattis