Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v19.1.0-beta.20190225: Unknown Event Types in the Web UI for automatic stats #35319

Closed
nstewart opened this issue Mar 2, 2019 · 6 comments · Fixed by #35425
Closed

v19.1.0-beta.20190225: Unknown Event Types in the Web UI for automatic stats #35319

nstewart opened this issue Mar 2, 2019 · 6 comments · Fixed by #35425
Assignees
@RaduBerinde @awoods187

Comments

@nstewart
Copy link
Contributor

nstewart commented Mar 2, 2019

Describe the problem

Automatic stats are creating unknown event types in the Web UI event log

image

To Reproduce

What did you do? Describe in your own words.
Ran the latest beta and sent some test load using https://github.com/cockroachdb/movr. Checked the WebUI and saw a bunch of unknown events.

Expected behavior
I'd expect these events to be labeled clearly
@awoods187
Copy link
Contributor

Can confirm this happens on SQL 20 too:

image

@RaduBerinde
Copy link
Member

Fixing the description for the event is easy: https://github.com/cockroachdb/cockroach/blob/master/pkg/ui/src/util/events.ts#L83

But I don't think we want this showing up as an event since it will be very spammy, and in principle it's not something that a user should need to be concerned with.

@RaduBerinde RaduBerinde self-assigned this Mar 4, 2019
@awoods187
Copy link
Contributor

@RaduBerinde are all jobs events? it does seem spammy to have it be both an event and a job

@RaduBerinde
Copy link
Member

No, there is special code to issue an event. I'll add a cluster setting and turn it off by default.

@RaduBerinde
Copy link
Member

I am planning to make the following improvements:

  • cluster setting to control these events, off by default
  • when events are on, they should have a useful message that contains the table name
  • similarly, the job description should have human-readable information including the table name, not the SQL statement

@awoods187
Copy link
Contributor

that sounds great

@RaduBerinde RaduBerinde mentioned this issue Mar 5, 2019
Merged
craig bot pushed a commit that referenced this issue Mar 5, 2019
@RaduBerinde
Merge #35425
f0f024d 
35425: stats: improve UI experience r=RaduBerinde a=RaduBerinde

This change makes the following improvements:

 - the job name is now a user-friendly message (instead of the exact SQL
   statement) for automatic table stats. The message includes the
   fully-qualified tale name (the table name was not visible at all).

 - the event description in the UI is fixed (used to be an "unknown
   event error"); the message includes the FQ table name.

 - events are not posted by default (they are too spammy and redundant
   with the jobs); but they can be turned on via a cluster setting
   (could be useful during debugging).

Release note (admin ui change): CREATE STATISTICS jobs no longer
generate events by default; improved descriptions for automatic
statistics jobs.

Fixes #35319.

Co-authored-by: Radu Berinde <[email protected]>
@craig craig bot closed this as completed in #35425 Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

@awoods187 awoods187

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stats: improve UI experience RaduBerinde/cockroach
3 participants
@nstewart @RaduBerinde @awoods187