Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamcity: failed test: TestLint #34059

Closed
cockroach-teamcity opened this issue Jan 16, 2019 · 0 comments
Closed

teamcity: failed test: TestLint #34059

cockroach-teamcity opened this issue Jan 16, 2019 · 0 comments
Assignees
@petermattis
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
19.1

Comments

@cockroach-teamcity
Copy link
Member

The following tests appear to have failed on master (lint): TestLint/TestVet, TestLint

You may want to check for open issues.

#1096909:

TestLint/TestVet
--- FAIL: lint/TestLint: TestLint/TestVet (167.940s)

------- Stdout: -------
=== PAUSE TestLint/TestVet
        lint_test.go:1087: 
            In file included from wrap-common.c:1:
        lint_test.go:1087: 
            In file included from vendor/github.com/knz/go-libedit/unix/src/libedit-common.c:1:
        lint_test.go:1087: 
            vendor/github.com/knz/go-libedit/unix/src/c-libedit/common.c:371:21: warning: passing 'wint_t *' (aka 'unsigned int *') to parameter of type 'wchar_t *' (aka 'int *') converts between pointers to integer types with different sign [-Wpointer-sign]
        lint_test.go:1087: 
            vendor/github.com/knz/go-libedit/unix/src/c-libedit/histedit.h:267:37: note: passing argument to parameter here
        lint_test.go:1087: 
            In file included from wrap-search.c:1:
        lint_test.go:1087: 
            In file included from vendor/github.com/knz/go-libedit/unix/src/libedit-search.c:1:
        lint_test.go:1087: 
            vendor/github.com/knz/go-libedit/unix/src/c-libedit/search.c:607:20: warning: passing 'wint_t *' (aka 'unsigned int *') to parameter of type 'wchar_t *' (aka 'int *') converts between pointers to integer types with different sign [-Wpointer-sign]
        lint_test.go:1087: 
            vendor/github.com/knz/go-libedit/unix/src/c-libedit/histedit.h:267:37: note: passing argument to parameter here



TestLint
--- FAIL: lint/TestLint (191.870s)

Please assign, take a look and update the issue accordingly.
@cockroach-teamcity cockroach-teamcity added this to the 2.2 milestone Jan 16, 2019
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 16, 2019
@petermattis petermattis self-assigned this Jan 16, 2019
petermattis added a commit to petermattis/cockroach that referenced this issue Jan 16, 2019
@petermattis
build: skip TestLint/TestVet
fb3a3a1 
Temporarily skip `TestLint/TestVet` until the upstream warnings can be
silenced.

See cockroachdb#34059

Release note: None
@petermattis petermattis mentioned this issue Jan 16, 2019
Merged
craig bot pushed a commit that referenced this issue Jan 17, 2019
@petermattis
Merge #34070
0519d1a 
34070: build: skip TestLint/TestVet r=andy-kimball a=petermattis

Temporarily skip `TestLint/TestVet` until the upstream warnings can be
silenced.

See #34059

Release note: None

Co-authored-by: Peter Mattis <[email protected]>
@petermattis petermattis mentioned this issue Jan 17, 2019
Merged
petermattis added a commit to petermattis/cockroach that referenced this issue Jan 17, 2019
@petermattis
*: bump github.com/knz/go-libedit
e69f398 
This picks up a change which silences the pointer-sign conversion
warnings which were in turn causing `TestLint/TestVet` to error
spuriously.

Fixes cockroachdb#34059

Release note: None
craig bot pushed a commit that referenced this issue Jan 17, 2019
@petermattis
Merge #34069 #34086
734fb0e 
34069: *: bump github.com/knz/go-libedit r=jordanlewis,knz a=petermattis

This picks up a change which silences the pointer-sign conversion warnings which were in turn causing `TestLint/TestVet` to error spuriously.

Fixes #34059

Release note: None

34086: build: clear GOFLAGS when invoking `go install` r=tbg a=petermattis

Similar to the previous `GOFLAGS` fix, we need to make sure the
`GOFLAGS` env variable is cleared when invoking `go install` as we're
passing those flags on the command line as well. go1.11 added support
for parsing the `GOFLAGS` environment variable, but that support is not
identical to passing those flags on the command line (e.g. there is a
difference between `-o foo` and `-o=foo`).

Fixes #34083

Release note: None

Co-authored-by: Peter Mattis <[email protected]>
@craig craig bot closed this as completed in #34069 Jan 17, 2019
@petermattis petermattis mentioned this issue Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
2 participants
@petermattis @cockroach-teamcity