Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgwire,sql: extra_float_digits is not propagated properly from client settings #30698

Closed
knz opened this issue Sep 26, 2018 · 0 comments
Closed

pgwire,sql: extra_float_digits is not propagated properly from client settings #30698

knz opened this issue Sep 26, 2018 · 0 comments
Assignees
@knz
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgwire pgwire protocol issues. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-erroneous-edge-case Database produces or stores erroneous data without visible error/warning, in rare edge cases.

Comments

@knz
Copy link
Contributor

knz commented Sep 26, 2018

When a pgwire client sets up the connection they can provide initial client parameters like application_name.

Most clients, including lib/pq and psql, expect to be able to specify extra_float_digits because they consider the default (0) to be an unsuitable default.

Currently CockroachDB drops this configuration on the floor and defaults to 0 always. This is incorrect on its face, and can also cause clients to start reporting invalid/unexpected float values to clients.
@knz knz added A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgwire pgwire protocol issues. S-3-erroneous-edge-case Database produces or stores erroneous data without visible error/warning, in rare edge cases. labels Sep 26, 2018
@knz knz self-assigned this Sep 26, 2018
@knz knz mentioned this issue Sep 26, 2018
Merged
@knz knz added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Oct 2, 2018
craig bot pushed a commit that referenced this issue Oct 5, 2018
@knz
Merge #30702
5e7d47a 
30702: sql,pgwire: fix a host of pgwire/sql interaction bugs r=knz a=knz

First commit from #30691.

Fixes #30701.
Fixes #30692.
Fixes #30693.
Fixes #30697.
Fixes #30698.
Fixes #30703.
Informs #30717.

With special thanks to @benesch for asking me to poke at this.

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in #30702 Oct 5, 2018
@knz knz mentioned this issue Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgwire pgwire protocol issues. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-erroneous-edge-case Database produces or stores erroneous data without visible error/warning, in rare edge cases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knz