Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: set cluster setting $1 produces silly event logs #28992

Closed
benesch opened this issue Aug 23, 2018 · 0 comments
Closed

sql: set cluster setting $1 produces silly event logs #28992

benesch opened this issue Aug 23, 2018 · 0 comments
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@benesch
Copy link
Contributor

benesch commented Aug 23, 2018

Running SET CLUSTER SETTING $1 (i.e., as a prepared statement with a placeholder) produces a silly event log:

I180823 02:08:50.865654 1726 sql/event_log.go:126  [n1,client=127.0.0.1:57338,user=root] Event: "set_cluster_setting", target: 0, info: {SettingName:sql.test_setting Value:$1 User:root}

We should put the actual value into the event log, not the placeholder.

Not sure what sql label to use for this. /cc @knz for triage

dt added a commit to dt/cockroach that referenced this issue Aug 23, 2018
previously we'd include the pre-rendered expression, which is particularly useless with placeholders.

Fixes cockroachdb#28992.

Release note: none.
@knz knz added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 23, 2018
craig bot pushed a commit that referenced this issue Aug 23, 2018
29014: sql: put rendered setting value in event log entry r=dt a=dt

previously we'd include the pre-rendered expression, which is particularly useless with placeholders.

Fixes #28992.

Release note: none.

Co-authored-by: David Taylor <[email protected]>
@craig craig bot closed this as completed in #29014 Aug 23, 2018
benesch pushed a commit to benesch/cockroach that referenced this issue Aug 27, 2018
previously we'd include the pre-rendered expression, which is particularly useless with placeholders.

Fixes cockroachdb#28992.

Release note: none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

3 participants