Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Flake in test_error_hints.tcl #28525

Closed
bdarnell opened this issue Aug 13, 2018 · 1 comment
Closed

cli: Flake in test_error_hints.tcl #28525

bdarnell opened this issue Aug 13, 2018 · 1 comment
Assignees
@knz

Comments

@bdarnell
Copy link
Contributor

This test was added in #28200 and flaked in https://teamcity.cockroachdb.com/viewLog.html?buildId=828646&buildTypeId=Cockroach_UnitTests

.180810 19:36:16.224734335 EXPECT TEST: START TEST: Connecting a RPC client to a non-started server
.180810 19:36:16.355892170 EXPECT TEST: END TEST
.180810 19:36:16.361239379 EXPECT TEST: START TEST: Connecting a SQL client to a non-started server
.180810 19:36:16.491503873 EXPECT TEST: END TEST
.180810 19:36:17.094520509 EXPECT TEST: START TEST: Connecting a secure RPC client to an insecure server
.180810 19:36:17.163611196 EXPECT TEST: END TEST
.180810 19:36:17.168570126 EXPECT TEST: START TEST: Connecting a secure SQL client to an insecure server
.180810 19:36:17.237626433 EXPECT TEST: END TEST
.180810 19:36:17.243235292 EXPECT TEST: INTERRUPT TO FOREGROUND PROCESS
.180810 19:36:17.649516890 EXPECT TEST: INTERRUPT TO FOREGROUND PROCESS
.180810 19:36:18.835451035 EXPECT TEST: START TEST: Connecting an insecure RPC client to a secure server
.180810 19:36:48.907076700 EXPECT TEST: TIMEOUT WAITING FOR "Error: server closed the connection."
@bdarnell bdarnell mentioned this issue Aug 13, 2018
Merged
@knz
Copy link
Contributor

knz commented Aug 13, 2018

Good catch. I actually knew I had to handle this case but because it's not deterministic I had forgotten.

@knz knz mentioned this issue Aug 13, 2018
Merged
craig bot pushed a commit that referenced this issue Aug 13, 2018
@emsal0 @knz
Merge #28333 #28528
de5978a 
28333: sql: Add a new foreign key check benchmark test for interleaved tables r=emsal1863 a=emsal1863

Previously, the only deletion benchmark for interleaved tables tested
deletes on the child table. This new benchmark tests the performance of
deletes on the parent table to cover the case and test the performance
of cascading deletes in interleaved tables.

Release note: None

28528: cli: fix flake in test_error_hints.tcl r=knz a=knz

Fixes #28525.

It's possible for a RPC client to connects to a server during server
initialization after the socket has been set up but before the TLS
context has been fully initialized. In that case the connection will
simply abort with no error, with a recommendation for the client to
retry (TransientFailure).

This patch extends the "error hinting" logic of CLI commands to
recognize this case too.

Release note: None

Co-authored-by: Emmanuel <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in #28528 Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdarnell @knz