libroach: ensure CryptoPP is built with hardware detection enabled #26383
Assignees
Labels
Comments
mberhault
pushed a commit
to mberhault/cockroach
that referenced
this issue
Jun 13, 2018
Fixes cockroachdb#26383 Set appropriate `-m` flags for cryptopp to enable AES runtime detection checks (without those, it does not even try). Add a `UsesAESNI()` function in CryptoPP which returns true iff: * AES-NI runtime detection is compiled in * AES-NI instruction is available Add a warning to stdout (normal logging requires `vmodule=rocksdb=3`) if encryption is requested but AES-NI is not available. Add a test to make sure our builds always have AES-NI enabled. Release note (core): build release binaries with runtime AES detection.
craig bot
pushed a commit
that referenced
this issue
Jun 14, 2018
26649: libroach: make CryptoPP build with runtime AES-NI detection. r=mberhault a=mberhault Fixes #26383 Set appropriate `-m` flags for cryptopp to enable AES runtime detection checks (without those, it does not even try). Add a `UsesAESNI()` function in CryptoPP which returns true iff: * AES-NI runtime detection is compiled in * AES-NI instruction is available Add a warning to stdout (normal logging requires `vmodule=rocksdb=3`) if encryption is requested but AES-NI is not available. Add a test to make sure our builds always have AES-NI enabled. Release note (core): build release binaries with runtime AES detection. Co-authored-by: marc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As seen in #26261 the
release-linux-gnubuild seems to have hardware detection turned off, so CryptoPP doesn't even try to see if the AES instruction set is supported. We should make sure we build it correctly.The text was updated successfully, but these errors were encountered: