Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: make watch broken #25858

Closed
vilterp opened this issue May 23, 2018 · 1 comment
Closed

ui: make watch broken #25858

vilterp opened this issue May 23, 2018 · 1 comment
Assignees
@vilterp

Comments

@vilterp
Copy link
Contributor

vilterp commented May 23, 2018 •
edited
Loading

Because in #25195 we moved index.html from being a static file that Webpack would serve up to being a Go template (for login purposes). Webpack is now falling back on generating its own index.html, which is useless. We need to tell Webpack to proxy / through to the cockroach process like it does for API endpoints.

cc @couchand
@vilterp vilterp self-assigned this May 23, 2018
@vilterp vilterp mentioned this issue May 23, 2018
Merged
vilterp pushed a commit to vilterp/cockroach that referenced this issue May 23, 2018
ui: unbreak make watch
f186673 
By telling Webpack to proxy the path `/` through to the Cockroach process.
Webpack used to serve `/` itself from a static file, but as of cockroachdb#25195 we
generate `/` dynamically in Go, so we can use it to pass login state to
the UI.

Fixes cockroachdb#25858

Release note: None
vilterp pushed a commit to vilterp/cockroach that referenced this issue May 23, 2018
ui: unbreak make watch
16c1df7 
By telling Webpack to proxy the path `/` through to the Cockroach process.
Webpack used to serve `/` itself from a static file, but as of cockroachdb#25195 we
generate `/` dynamically in Go, so we can use it to pass login state to
the UI.

Fixes cockroachdb#25858

Release note: None
@vilterp
Copy link
Contributor Author

vilterp commented May 23, 2018

cc @mberhault — fix is in the bors queue.

craig bot pushed a commit that referenced this issue May 23, 2018
@a-robinson @couchand
Merge #25868 #25871 #25875
4a5eba4 
25868: sql: Log event for TRUNCATE TABLE r=a-robinson a=a-robinson

Fixes #25867

Release note (sql change): TRUNCATE TABLE commands are now logged in the
event log.

25871: ui: unbreak `make watch` r=vilterp a=vilterp

By telling Webpack to proxy the path `/` through to the Cockroach process.
Webpack used to serve `/` itself from a static file, but as of #25195 we
generate `/` dynamically in Go, so we can use it to pass login state to
the UI.

Fixes #25858

Release note: None

25875: ui: fix action names broken by #25823 r=couchand a=couchand

In that PR, I mechanically replaced identifiers when there were new
warnings about shadowing, but in two places I accidentally changed
semantics due to the shorthand form of object literals.  🤦‍♂️

Release note: None

Co-authored-by: Alex Robinson <[email protected]>
Co-authored-by: Pete Vilter <[email protected]>
Co-authored-by: Andrew Couch <[email protected]>
@craig craig bot closed this as completed in #25871 May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilterp vilterp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vilterp