Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Create UI components for login screen #24939

Closed
piyush-singh opened this issue Apr 19, 2018 · 0 comments
Closed

ui: Create UI components for login screen #24939

piyush-singh opened this issue Apr 19, 2018 · 0 comments
Assignees
@vilterp
Labels
A-webui-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
2.1

Comments

@piyush-singh
Copy link

Sub-task for #6307.

This issue is to track front end work for authenticating users as outlined in the above issue. Some states we should consider:

  • Default login prompt when first accessing the UI
  • Invalid username
  • Invalid password
  • Logging out once logged in

Including an early design from Kuan that was added in the above issue:
image

@josueeee as discussed, this will need some design attention. cc @vilterp and @couchand
@piyush-singh piyush-singh added this to the 2.1 milestone Apr 19, 2018
@vilterp vilterp self-assigned this Apr 19, 2018
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) and removed feature labels Apr 24, 2018
@vilterp vilterp mentioned this issue Apr 24, 2018
Merged
5 tasks
@couchand couchand mentioned this issue May 15, 2018
Closed
craig bot pushed a commit that referenced this issue May 22, 2018
@couchand @solongordon
Merge #25005 #25628
81f3b01 
25005: ui: add top-level LoginContainer: require login before rendering anything r=couchand a=vilterp

Depends on #25057 
Touches #24939

![](https://user-images.githubusercontent.com/7341/39150096-38b4cd28-470f-11e8-9d67-e1832d35a211.gif)

Shown above:
1. go to admin UI; see login screen
2. error message when you type in the wrong password
3. you can't hit an authenticated endpoint because you don't have a valid session (this checking is turned on by #24944, only in secure mode)
4. once you login with the right password, you can see the UI (the temporary "connection lost" banner shouldn't be there)
5. now you (and the UI itself) can hit endpoints, because you have a valid session

Todos:
- [ ] redirect to login page instead of current wrapper component switching thing
- [ ] logout
    - [ ] logout button (make API call; redirect to login & blow away redux store)
    - [ ] log out other tabs (if they get a 403, redirect to login & blow away redux store)
- [ ] styling

Release note: None

25628: distsql: support lookup join on secondary index r=solongordon a=solongordon

joinReader now supports lookup joins on secondary indexes. This was a
trivial change for queries where all the output columns are included in
the secondary index. I just modified the physical planner to specify the
secondary index in the JoinReaderSpec and removed checks which prevented
secondary indexes from being used.

The more complicated situation is when we want to do a lookup join
against a non-covering index. In this case, the logical planner plans an
index join before the inner join, but we want to perform the lookup join
first. We now handle this by only planning the lookup join during
physical planning, not the index join. During execution, the joinReader
detects that there are output columns not covered by the secondary
index, and it performs primary index lookups as necessary to retrieve
the additional columns.

Fixes #25431

Co-authored-by: Pete Vilter <[email protected]>
Co-authored-by: Andrew Couch <[email protected]>
Co-authored-by: Solon Gordon <[email protected]>
couchand added a commit to couchand/cockroach that referenced this issue May 29, 2018
@couchand
ui: style login page
f8902a6 
Add some initial styling to the login page.

Contributes to cockroachdb#24939.

Release note: None
couchand added a commit to couchand/cockroach that referenced this issue May 29, 2018
@couchand
ui: error state for login page
688608c 
Add some styling and clean up the error text on login page.

Contributes to cockroachdb#24939.

Release note: None
couchand added a commit to couchand/cockroach that referenced this issue Jun 4, 2018
@couchand
ui: style login page
18c515f 
Add some initial styling to the login page.

Contributes to cockroachdb#24939.

Release note: None
couchand added a commit to couchand/cockroach that referenced this issue Jun 4, 2018
@couchand
ui: error state for login page
e895d13 
Add some styling and clean up the error text on login page.

Contributes to cockroachdb#24939.

Release note: None
@couchand couchand mentioned this issue Jun 4, 2018
Merged
couchand added a commit to couchand/cockroach that referenced this issue Jun 7, 2018
@couchand
ui: style login page
a9f74ae 
Add some initial styling to the login page.

Contributes to cockroachdb#24939.

Release note: None
couchand added a commit to couchand/cockroach that referenced this issue Jun 7, 2018
@couchand
ui: error state for login page
b966f7c 
Add some styling and clean up the error text on login page.

Contributes to cockroachdb#24939.

Release note: None
craig bot pushed a commit that referenced this issue Jun 7, 2018
@couchand
Merge #26066
26fe882 
26066: ui: style login page r=couchand a=couchand

Adds some initial styling to the login page and the login indicator in the navigation sidebar.

Sidebar:
<img width="710" alt="screen shot 2018-05-29 at 1 59 44 pm" src="https://user-images.githubusercontent.com/793969/40676560-110e3a7e-6349-11e8-812a-9c8e682f5670.png">

Login page:
<img width="1274" alt="screen shot 2018-06-04 at 4 28 40 pm" src="https://user-images.githubusercontent.com/793969/40940739-c0c6eb10-6816-11e8-9b24-8a0b492239b3.png">

Login page with error:
<img width="1277" alt="screen shot 2018-06-04 at 4 45 40 pm" src="https://user-images.githubusercontent.com/793969/40940744-c4cb2d66-6816-11e8-90d4-d8b3c52927b6.png">

Insecure mode (temporary design):
<img width="161" alt="screen shot 2018-06-04 at 5 10 56 pm" src="https://user-images.githubusercontent.com/793969/40942388-016f9478-681c-11e8-929c-36d0b7aa7463.png">

Closes #24939.

Co-authored-by: Andrew Couch <[email protected]>
@craig craig bot closed this as completed in #26066 Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilterp vilterp

Labels
A-webui-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
4 participants
@vilterp @knz @couchand @piyush-singh