-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/sqlccl: TestBackupRestoreControlJob failed under stress #21846
Comments
SHA: https://github.com/cockroachdb/cockroach/commits/40a7b4e6677987d8235d5b607832c3dbf20a8f2b Parameters:
Stress build found a failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=495848&tab=buildLog |
Fixes cockroachdb#21828. Fixes cockroachdb#21846. Fixes cockroachdb#21844. Fixes cockroachdb#21808. See discussion in cockroachdb#21802. We were previously ignoring the errors returned by job operations in a few places. This meant that we would fail to propagate retryable txn errors when using the jobs API and we could think a txn succeeded when it didn't. This change fixes that. In doing so, it makes schema changes fail when they see errors due to job status updates. I don't see a compelling reason why the old behavior was better and I suspect it was allowing subtle inconsistencies. Release note: None
SHA: https://github.com/cockroachdb/cockroach/commits/6a1cc888163fd154f80c1748837f2a6e10e62fe4 Parameters:
Stress build found a failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=505494&tab=buildLog |
SHA: https://github.com/cockroachdb/cockroach/commits/c93d304f8b31b5b0678a46d36a7b751cf50fedb1 Parameters:
Stress build found a failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=513425&tab=buildLog |
Fixes cockroachdb#21828. Fixes cockroachdb#21846. Fixes cockroachdb#21844. Fixes cockroachdb#21808. See discussion in cockroachdb#21802. We were previously ignoring the errors returned by job operations in a few places. This meant that we would fail to propagate retryable txn errors when using the jobs API and we could think a txn succeeded when it didn't. This change fixes that. In doing so, it makes schema changes fail when they see errors due to job status updates. I don't see a compelling reason why the old behavior was better and I suspect it was allowing subtle inconsistencies. Release note: None
SHA: https://github.com/cockroachdb/cockroach/commits/2c85c61e7bc64c7c62aa7e25e9e762180f4e345a
Parameters:
Stress build found a failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=495189&tab=buildLog
The text was updated successfully, but these errors were encountered: