Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlbase: RandDatum should produce negative DInts #20902

Closed
danhhz opened this issue Dec 19, 2017 · 0 comments
Closed

sqlbase: RandDatum should produce negative DInts #20902

danhhz opened this issue Dec 19, 2017 · 0 comments
Assignees
@danhhz
Labels
A-partitioning
Milestone
2.0

Comments

@danhhz
Copy link
Contributor

danhhz commented Dec 19, 2017

It currently does rng.Int63() which the stdlib docs says "returns a non-negative pseudo-random 63-bit integer". It seems like we really should be generating negative ints in our random testing. The other types should all also be audited for this same bug.
@danhhz danhhz added this to the 2.0 milestone Dec 19, 2017
@danhhz danhhz self-assigned this Dec 19, 2017
danhhz added a commit to danhhz/cockroach that referenced this issue Dec 28, 2017
@danhhz
sqlbase/testutils: also produce negatives in RandDatum
973ebf4 
Closes cockroachdb#20902.

Release note: None
@danhhz danhhz mentioned this issue Dec 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danhhz danhhz

Labels
A-partitioning
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@danhhz