Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jepsen: More nemeses, flexible configuration #19697

Closed
bdarnell opened this issue Oct 31, 2017 · 1 comment
Closed

jepsen: More nemeses, flexible configuration #19697

bdarnell opened this issue Oct 31, 2017 · 1 comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@bdarnell
Copy link
Contributor

Our jepsen tests support some nemesis configurations that we are not currently using: split, and a family of -skews configurations. We should enable both the split nemesis and at least one of the skews nemeses.

We currently run each (test, nemesis) combination for six minutes, so adding a new nemesis adds a significant amount of runtime to the test suite. The failure noted in #17815 occurs once per several hours of runtime, so increasing the test duration would improve our ability to find failures like this. However, adding configurations or increasing runtime has a cost in machine resources. We should figure out how we want to handle this, which may include running some test+nemesis configurations longer than others. For example, the sets and sequential tests seem to be our most sensitive ones; the other tests have rarely noticed an issue that wasn't also caught by one of those too, so we should give them a larger fraction of our test runtime budget.

@bdarnell bdarnell added this to the Later milestone Oct 31, 2017
bdarnell added a commit to bdarnell/cockroach that referenced this issue Nov 8, 2017
Enable more nemeses: subcritical-skews, strobe-skews, split
Enable more tests: bank-mulittable, g2

Updates cockroachdb#19697
bdarnell added a commit to bdarnell/cockroach that referenced this issue Nov 9, 2017
Enable more nemeses: subcritical-skews, split
Enable more tests: bank-mulittable, g2

Disable the comments test, which is expected to fail (in practice, it
only fails with one of the skew nemeses).

Decrease running time per configuration from 6m to 5m to slightly
offset the increased number of configurations. Running the full matrix
produces enough logs to fill up the workers' disks without this
change.

Updates cockroachdb#19697
@bdarnell bdarnell added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure labels Apr 26, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

2 participants