-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterviz: cluster overview #19512
Comments
could you also add something regarding what the different shades of gray mean for the "Capacity Usage" bar? |
@couchand added in your open source cluster overview version into this. thanks!! |
Just edited the issue with the outcome of some meatspace discussions: support collapsing the overview and we're punting on the grey background for now. |
@dianasaur323 I'm thinking it doesn't make sense to have the node liveness link to the node list: it's already on this page. Also, since it's on this page, we can probably just get rid of the dedicated node list page, right? |
@couchand Well, the problem is that in the CCL version, we would no longer have this page. How can we reconcile the two? |
As I understand it, the CCL version will still have the node list, it will just be a panel coming up from the bottom rather than taking up the whole page. Is that not still the plan? |
I believe for the next release, we won't have the node list coming p from the bottom. But now that I think about it, perhaps we can just bring the current node list there, and have that behavior? |
Yes, @couchand and I discussed offline. We will just wrap the node list into the cluster overview, and it sounds like it won’t be hard to have it expandable. |
On #19908 @tschottdorf mentioned that the capacity bar chart is unintuitive. I think the reason is that the total capacity doesn't actually appear anywhere except for encoded in the length of the grey background. Perhaps we should add it. There are two places I could see putting it:
|
I think 1 might cause us to have tick marks that don't fall in a natural looking spot. Enlisting @kuanluo to provide her thoughts. I was about to offer up an opinion, but I think it would be ugly :) |
Ha, Josué's original mock have the tick labels, so I am in favor of Option 1. |
Sounds like we might have to do some testing on different browsers before shipping as well, so added that as a little tick mark. Let's talk about what that actually means tomorrow during our cluster viz meeting. |
Closes cockroachdb#19512. Release note: None
🎉 |
[ ] Pull top entry of event log as the last event + timestamp (when it started / occurred)(moved to clusterviz: cluster overview enhancements #20540)[ ] Link to full event log(moved to clusterviz: cluster overview enhancements #20540)[ ] Node liveness needs to point to the node list - we may need to add a link here @kuanluo[ ] Let's break up the different shades of grey by 20%. So lightest grey is 20% full, 2nd lightest grey is 40% full, and so on.[ ] Support collapsing the overview to get more space for the node list/node canvas.(moved to clusterviz: cluster overview enhancements #20540)[ ] Top bar is responsive, where as node list is fixed width - find a more elegant solution for this(moved to clusterviz: cluster overview enhancements #20540)cc @kuanluo @vilterp @couchand @mrtracy @cuongdo
The text was updated successfully, but these errors were encountered: