-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamcity: failed tests on master: test/TestRefreshPendingCommands/#00, test/TestRefreshPendingCommands #18554
Labels
Milestone
Comments
cockroach-teamcity
added
O-robot
Originated from a bot.
C-test-failure
Broken test (automatically or manually discovered).
labels
Sep 18, 2017
This keeps happening to me on TC. Peter, do you happen to know what this SIGQUIT is about? |
@andreimatei No, I don't. It is on my TODO list to investigate. I wasn't able to reproduce it locally when I tried a few days ago. |
This was referenced Oct 3, 2017
tbg
added a commit
to tbg/cockroach
that referenced
this issue
Oct 20, 2017
The test ran a for loop without preemption points. The loop checked a condition that would only become true after another goroutine had been scheduled and carried out its job. If, with only few cores (four in my case) GC kicked in before that other goroutine got scheduled, that loop would just run hot forever until the test timed out, and the resulting stack dump looked quite unhelpful. Add a small sleep so the runtime can preempt the goroutine. The issue was harder to run into when stressing only the test, since there was less garbage available at that point. Adding some print statements, I accidentally made it much more likely. Previously flaked (got stuck) within <500iters, now ran past 1.5k without problems. Fixes cockroachdb#19397. Fixes cockroachdb#19388. Touches cockroachdb#19367. Fixes cockroachdb#18554.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The following tests appear to have failed:
#354447:
Please assign, take a look and update the issue accordingly.
The text was updated successfully, but these errors were encountered: