*: prefer log.Fatal to panic for assertions #16479
Labels
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
S-3-productivity
Severe issues that impede the productivity of CockroachDB developers.
Milestone
Comments
petermattis
added a commit
to petermattis/cockroach
that referenced
this issue
Jun 13, 2017
panic causes stacks to unwind and defers to be invoked (possibly
releasing locks) until eventually something either handles the
panic (unlikely) or we reach the runtime and it kills the process. While
the process is dying, other goroutines are still running which may
encounter invalid states due to the panic. These invalid states can
produce fatal errors of there own which seem impossible and are
difficult to debug. For fatal errors we should use log.Fatal{,f} instead
which will kill the process before any locks are released.
See cockroachdb#16479
knz
added
the
S-3-productivity
petermattis
added
the
C-cleanup
|
@petermattis think it adds value to keep this open? |
|
No, it doesn't. The message still stands, but better to engrave it in our brains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
paniccauses stacks to unwind and defers to be invoked (possibly releasing locks) until eventually something either handles the panic (unlikely) or we reach the runtime and it kills the process. While the process is dying, other goroutines are still running which may encounter invalid states due to the panic. For fatal errors we should uselog.Fatal{,f}instead which will kill the process before any locks are released.I'm not sure if a massive search-and-replace is warranted, but some key packages such as
storagedeserve attention.See #16460 for motivation.
The text was updated successfully, but these errors were encountered: