Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: schemachange/random-load failed [column is referenced by the primary key] #136405

Closed
cockroach-teamcity opened this issue Nov 29, 2024 · 2 comments · Fixed by #136738
Closed

roachtest: schemachange/random-load failed [column is referenced by the primary key] #136405

cockroach-teamcity opened this issue Nov 29, 2024 · 2 comments · Fixed by #136738
Assignees
@fqazi
Labels
branch-master Failures and bugs on the master branch. branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 29, 2024 •
edited by cockroach-jira-scripts
Loading

roachtest.schemachange/random-load failed with artifacts on master @ 7d48198a57f014a8828194b90098699f70f0695a:

(schemachange_random_load.go:129).runSchemaChangeRandomLoad: full command output in run_132342.324792324_n1_workload-run-schemac.log: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/schemachange/random-load/run_1

Parameters:

  • arch=amd64
  • cloud=gce
  • coverageBuild=false
  • cpu=4
  • encrypted=false
  • fs=ext4
  • localSSD=true
  • metamorphicLeases=default
  • runtimeAssertionsBuild=false
  • ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-45022
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Nov 29, 2024
@cockroach-teamcity cockroach-teamcity mentioned this issue Dec 2, 2024
Closed
@fqazi fqazi self-assigned this Dec 3, 2024
@fqazi
Copy link
Collaborator

fqazi commented Dec 3, 2024

Dup of #132298

@fqazi fqazi changed the title roachtest: schemachange/random-load failed roachtest: schemachange/random-load failed [column is referenced by the primary key] Dec 3, 2024
@exalate-issue-sync exalate-issue-sync bot changed the title roachtest: schemachange/random-load failed [column is referenced by the primary key] roachtest: schemachange/random-load failed Dec 3, 2024
@exalate-issue-sync exalate-issue-sync bot changed the title roachtest: schemachange/random-load failed roachtest: schemachange/random-load failed [column is referenced by the primary key] Dec 3, 2024
@fqazi fqazi removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Dec 3, 2024
@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Dec 3, 2024
@fqazi fqazi mentioned this issue Dec 4, 2024
Closed
fqazi added a commit to fqazi/cockroach that referenced this issue Dec 4, 2024
@fqazi
workload/schemachanger: fix drop columns during PK swaps
0b34da9 
Previously, if a declarative alter primary key and drop column were
executed concurrently this workload did not correctly pick the correct
columns. It was possible for the new primary key column to be selected
for the drop operation. To address this, this patch allows potential
execution errors for invalid column references when a PK swap is in
progress.

Fixes: cockroachdb#134056
Fixes: cockroachdb#136661
Fixes: cockroachdb#136405
Fixes: cockroachdb#132298

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Dec 4, 2024
@fqazi
workload/schemachanger: fix drop columns during PK swaps
8b8b598 
Previously, if a declarative alter primary key and drop column were
executed concurrently this workload did not correctly pick the correct
columns. It was possible for the new primary key column to be selected
for the drop operation. To address this, this patch allows potential
execution errors for invalid column references when a PK swap is in
progress.

Fixes: cockroachdb#134056
Fixes: cockroachdb#136661
Fixes: cockroachdb#136405
Fixes: cockroachdb#132298

Release note: None
@fqazi fqazi mentioned this issue Dec 4, 2024
Merged
craig bot pushed a commit that referenced this issue Dec 5, 2024
@fqazi @dt @rafiss
Merge #136738 #136754 #136803 #136804
f9a6082 
136738: workload/schemachanger: fix drop columns during PK swaps r=fqazi a=fqazi

Previously, if a declarative alter primary key and drop column were executed concurrently this workload did not correctly pick the correct columns. It was possible for the new primary key column to be selected for the drop operation. To address this, this patch allows potential execution errors for invalid column references when a PK swap is in progress.

Fixes: #134056
Fixes: #136661
Fixes: #136405
Fixes: #132298

Release note: None

136754: revert: move revertccl out of ccl r=dt a=dt

Release note: none.
Epic: none.

136803: scop: fix non-redaction of scop Type, Phase, and Stage r=rafiss a=rafiss

Epic: None
Release note: None

136804: builtins: fix handling of <1 seconds in make_timestamp{tz} r=rafiss a=rafiss

On some platforms, `make_timestamp(1, 1, 1, 0, 0, 0)` would return a value of `0293-09-22 00:12:43.145224 BC`. Now all platforms will compute the correct value of `0001-01-01 00:00:00`.

Also, on some platforms a fractional second value that is between 0 and 1 (exclusive), would always be interpeted as zero nanoseconds. Now it will always be converted to nanoseconds correctly.

fixes #126766
Release note (bug fix): Fixed a bug that would cause the make_timestamp and make_timestamptz builtin functions to incorrectly extract the `seconds` argument if the value was less than 1.

Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: David Taylor <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
@craig craig bot closed this as completed in 541a3d1 Dec 5, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 5, 2024

Based on the specified backports for linked PR #136738, I applied the following new label(s) to this issue: branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 label Dec 5, 2024
blathers-crl bot pushed a commit that referenced this issue Dec 5, 2024
@fqazi
workload/schemachanger: fix drop columns during PK swaps
fee2011 
Previously, if a declarative alter primary key and drop column were
executed concurrently this workload did not correctly pick the correct
columns. It was possible for the new primary key column to be selected
for the drop operation. To address this, this patch allows potential
execution errors for invalid column references when a PK swap is in
progress.

Fixes: #134056
Fixes: #136661
Fixes: #136405
Fixes: #132298

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Dec 5, 2024
Merged
fqazi added a commit that referenced this issue Dec 5, 2024
@fqazi
workload/schemachanger: fix drop columns during PK swaps
6e19976 
Previously, if a declarative alter primary key and drop column were
executed concurrently this workload did not correctly pick the correct
columns. It was possible for the new primary key column to be selected
for the drop operation. To address this, this patch allows potential
execution errors for invalid column references when a PK swap is in
progress.

Fixes: #134056
Fixes: #136661
Fixes: #136405
Fixes: #132298

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-master Failures and bugs on the master branch. branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload/schemachanger: fix drop columns during PK swaps fqazi/cockroach
2 participants
@fqazi @cockroach-teamcity