-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: explore use of direct IO for the RocksDB WAL #13620
Comments
cc @irfansharif - not sure, but maybe this option is something that would apply to the Raft log RocksDB instance? |
it does, have this in my notes somewhere. on my radar for when tuning RocksDB for raft log workload. |
In more recent RocksDB releases, the option became Enabling |
COCKROACH_USE_DIRECT_WRITES is not a knob that should be exposed at this time. See cockroachdb#13620
https://github.com/facebook/rocksdb/wiki/Direct-IO says:
I wonder why WAL I/O pattern is considered not suitable for direct I/O? Update: Sorry, didn't realise this issue is not in the facebook/rocksdb repo. Asked the same question here: https://groups.google.com/d/msg/rocksdb/hYT9_xSZmyw/maYMZj8CBQAJ |
RocksDB 5.1.2 added support for using direct IO (
O_DIRECT
) for writes. This might be a faster option than using fsync/fdatasync after writing the WAL.The text was updated successfully, but these errors were encountered: