Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: data race on the InputSyncSpec modification #133934

Closed
cockroach-teamcity opened this issue Oct 31, 2024 · 6 comments · Fixed by #134217 or mohini-crl/cockroach#49
Closed

colexec: data race on the InputSyncSpec modification #133934

cockroach-teamcity opened this issue Oct 31, 2024 · 6 comments · Fixed by #134217 or mohini-crl/cockroach#49
Assignees
Labels
A-disaster-recovery branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 31, 2024

ccl/streamingccl/streamingest.TestAlterTenantCompleteToTime failed with artifacts on release-23.1 @ a6e68054ec8a260b5fa4fde0bab38ffa64d4fd87:

      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7500 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x236
  github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler.StorePlanDiagram()
      github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler/profiler.go:38 +0x3e
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion.func2()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:106 +0x39d
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:117 +0x91c
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingest()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:270 +0x167
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingestWithRetries()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:297 +0x3a4
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.(*streamIngestionResumer).Resume()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:363 +0xb5
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7331 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x1506
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:377 +0x10df
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func3()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:219 +0xca
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func4()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:222 +0x47
==================

Parameters:

  • TAGS=bazel,gss,race
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-43838

@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Oct 31, 2024
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Oct 31, 2024
@cockroach-teamcity
Copy link
Member Author

ccl/streamingccl/streamingest.TestAlterTenantCompleteToTime failed with artifacts on release-23.1 @ deae9a6e30d886969c9999d89a7a4a893a71efd0:

      <autogenerated>:1 +0x64
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).txn()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:1700 +0x5fa
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).Txn()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:1635 +0xf0
  github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler.StorePlanDiagram.func1()
      github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler/profiler.go:43 +0x18e
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7627 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x1506
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:377 +0x10df
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func3()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:219 +0xca
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func4()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:222 +0x47

Goroutine 7792 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x236
  github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler.StorePlanDiagram()
      github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler/profiler.go:38 +0x3e
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion.func2()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:106 +0x39d
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:117 +0x91c
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingest()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:270 +0x167
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingestWithRetries()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:297 +0x3a4
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.(*streamIngestionResumer).Resume()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:363 +0xb5
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6
==================

Parameters:

  • TAGS=bazel,gss,race
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

ccl/streamingccl/streamingest.TestAlterTenantCompleteToTime failed with artifacts on release-23.1 @ b9f6e5a1db59289b6809bf7e75c09e1197e85c69:

      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7599 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x236
  github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler.StorePlanDiagram()
      github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler/profiler.go:38 +0x3e
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion.func2()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:106 +0x39d
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:117 +0x91c
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingest()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:270 +0x167
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingestWithRetries()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:297 +0x3a4
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.(*streamIngestionResumer).Resume()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:363 +0xb5
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7376 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x1506
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:377 +0x10df
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func3()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:219 +0xca
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func4()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:222 +0x47
==================

Parameters:

  • TAGS=bazel,gss,race
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

ccl/streamingccl/streamingest.TestAlterTenantCompleteToTime failed with artifacts on release-23.1 @ a20decf404b1659a49bdb2b862440c3d1c802912:

      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7640 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x236
  github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler.StorePlanDiagram()
      github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler/profiler.go:38 +0x3e
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion.func2()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:106 +0x39d
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:117 +0x91c
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingest()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:270 +0x167
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingestWithRetries()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:297 +0x3a4
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.(*streamIngestionResumer).Resume()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:363 +0xb5
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7422 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x1506
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:377 +0x10df
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func3()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:219 +0xca
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func4()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:222 +0x47
==================

Parameters:

  • TAGS=bazel,gss,race
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

ccl/streamingccl/streamingest.TestAlterTenantCompleteToTime failed with artifacts on release-23.1 @ a20decf404b1659a49bdb2b862440c3d1c802912:

      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7781 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x236
  github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler.StorePlanDiagram()
      github.com/cockroachdb/cockroach/pkg/jobs/jobsprofiler/profiler.go:38 +0x3e
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion.func2()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:106 +0x39d
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.startDistIngestion()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_dist.go:117 +0x91c
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingest()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:270 +0x167
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.ingestWithRetries()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:297 +0x3a4
  github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.(*streamIngestionResumer).Resume()
      github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/stream_ingestion_job.go:363 +0xb5
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1663 +0x1a2
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine()
      github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1664 +0xc51
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:469 +0x84b
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func2()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:383 +0x197
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:465 +0x1f6

Goroutine 7604 (running) created at:
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:456 +0x619
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:327 +0x1506
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:377 +0x10df
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func3()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:219 +0xca
  github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeClaimedJobs.func4()
      github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:222 +0x47
==================

Parameters:

  • TAGS=bazel,gss,race
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@dt
Copy link
Member

dt commented Nov 4, 2024

Looks like a data race that was introduced in #133758

@yuzefovich yuzefovich self-assigned this Nov 4, 2024
@yuzefovich yuzefovich moved this from Triage to Active in SQL Queries Nov 4, 2024
@yuzefovich yuzefovich changed the title ccl/streamingccl/streamingest: TestAlterTenantCompleteToTime failed colexec: data race on the InputSyncSpec modification Nov 4, 2024
craig bot pushed a commit that referenced this issue Nov 4, 2024
132877: kv: deflake TestLeaseQueueLeasePreferencePurgatoryError r=nvanbenschoten a=nvanbenschoten

Fixes #132652.

This commit fixes a flake in TestLeaseQueueLeasePreferencePurgatoryError where a delayed span config split could trip up the test and cause it to flake. We now wait for the span config split to be processed before waiting on the lease queue's purgatory, which should eliminate the flake.

Release note: None

133568: changefeedccl: add PTS to system.users r=andyyang890 a=asg0451

Add `system.users` to the list of system tables
that changefeeds protect with PTS. This table is
required for CDC Queries.

Part of: #128806

Release note (enterprise change): Add
`system.users` to the list of system tables that
changefeeds protect with PTS. This table is
required for CDC Queries.


133873: raft: ensure leaderMaxSupported does not regress when bumping terms r=nvanbenschoten a=arulajmani

Previously, it was possible for a leader to regress leaderMaxSupported by calling an election at a higher term. This was because we weren't careful to recognize this case on the leader, and followers had special case handling that allowed a leader to override `inFortifyLease`. Together, this could cause lease regressions for LeaderLeases in some rare cases.

This patch fixes this issue by removing special case handling in `inFortifyLease`. We also remove a special case in the handling of `MsgHup` which allowed a leader to step down and campaign without de-fortifying itself.

Fixes #133764

Release note: None

133895: ui: reroute v2 db page to legacy page when cluster is unfinalized r=xinhaoz a=xinhaoz

The migrations that support the v2 db page runs on finalization. Rather than show a non-functional page in an unfinalized cluster state let's reroute to the legacy page.

Epic: CRDB-37558
Fixes: #133843

Release note (ui change): The v2 db pages will only be available post ugprade finalization to 24.3. Prior to that we'll continue to show the legacy page when the cluster is in its unfinalized state.

134082: cli: improve tsdump upload concurrency behavior r=arjunmahishi a=dhartunian

- wrap concurrent error collection and status printing in necessary mutexes.
- reduce goroutine spawning to 10 for primary loop which avoids rate limit errors from datadog.

Release note: None

134216: sql/catalog: avoid multiple interface boxing allocs from `descpb.NameInfo` r=nvanbenschoten a=nvanbenschoten

When we cast a `descpb.NameInfo` to a `catalog.NameKey`, we incur at least one heap allocation to box the struct in an interface. This commit ensures that it's only one, and not multiple.

The change was motivated by observing two heap allocations in `lookupStoreCacheID`. Ideally, we would have no heap allocations here, but this is a step in the right direction.

While here, we also clean up a few similar cases.

```
name                            old time/op    new time/op    delta
Sysbench/SQL/oltp_read_only       36.3ms ± 4%    36.0ms ± 3%    ~     (p=0.730 n=9+9)
Sysbench/SQL/oltp_write_only      19.3ms ± 6%    18.8ms ± 4%  -2.36%  (p=0.043 n=9+10)
Sysbench/SQL/oltp_read_write      58.7ms ± 3%    57.2ms ± 2%  -2.49%  (p=0.000 n=10+10)
Sysbench/SQL/oltp_point_select    1.61ms ± 1%    1.56ms ± 2%  -2.59%  (p=0.000 n=9+10)
Sysbench/SQL/oltp_begin_commit     594µs ± 4%     608µs ± 7%    ~     (p=0.089 n=10+10)

name                            old alloc/op   new alloc/op   delta
Sysbench/SQL/oltp_read_only       1.05MB ± 1%    1.04MB ± 0%  -0.64%  (p=0.004 n=9+10)
Sysbench/SQL/oltp_write_only       405kB ± 1%     404kB ± 1%    ~     (p=0.720 n=9+10)
Sysbench/SQL/oltp_read_write      1.50MB ± 1%    1.51MB ± 1%    ~     (p=0.447 n=9+10)
Sysbench/SQL/oltp_point_select    35.3kB ± 2%    35.1kB ± 2%    ~     (p=0.278 n=9+10)
Sysbench/SQL/oltp_begin_commit    18.9kB ± 0%    18.9kB ± 1%    ~     (p=0.055 n=10+10)

name                            old allocs/op  new allocs/op  delta
Sysbench/SQL/oltp_read_only        6.96k ± 1%     6.86k ± 1%  -1.37%  (p=0.000 n=9+10)
Sysbench/SQL/oltp_write_only       3.62k ± 1%     3.58k ± 0%  -0.96%  (p=0.000 n=9+10)
Sysbench/SQL/oltp_read_write       11.0k ± 1%     10.9k ± 1%  -0.56%  (p=0.030 n=9+10)
Sysbench/SQL/oltp_point_select       317 ± 1%       312 ± 0%  -1.74%  (p=0.000 n=9+10)
Sysbench/SQL/oltp_begin_commit       140 ± 0%       140 ± 0%    ~     (p=1.000 n=10+10)
```

Epic: None
Release note: None

134217: sql: fix recently introduced data race r=yuzefovich a=yuzefovich

Recently, in a5b8d06 we introduced a possible data race. Namely, that change modifies a proto inside of the physical plan to cap the slice of types during the vectorized operator planning in order to prevent a type schema corruption due to slice aliasing. However, it's been assumed in a couple of places that the physical plan is immutable. This commit clarifies that the physical plan is immutable after its finalization and moves the capping into the finalization.

Fixes: #133934.

Release note: None

Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Miles Frankel <[email protected]>
Co-authored-by: Arul Ajmani <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: David Hartunian <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig craig bot closed this as completed in 0f616a7 Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Nov 4, 2024
Copy link

blathers-crl bot commented Nov 4, 2024

Based on the specified backports for linked PR #134217, I applied the following new label(s) to this issue: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
Archived in project
3 participants