Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/changefeedccl: TestChangefeedEachColumnFamilySchemaChanges failed #130404

Closed
cockroach-teamcity opened this issue Sep 10, 2024 · 1 comment
Closed

ccl/changefeedccl: TestChangefeedEachColumnFamilySchemaChanges failed #130404

cockroach-teamcity opened this issue Sep 10, 2024 · 1 comment
Assignees
@andyyang890
Labels
A-cdc Change Data Capture branch-release-24.2.1-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-cdc

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 10, 2024 •
edited by cockroach-jira-scripts
Loading

ccl/changefeedccl.TestChangefeedEachColumnFamilySchemaChanges failed on release-24.2.1-rc @ 95e6fb913c83be95110e0a250bcc75bbe863c8b1:

test logs left over in: outputs.zip/logTestChangefeedEachColumnFamilySchemaChanges4148822884
--- FAIL: TestChangefeedEachColumnFamilySchemaChanges (15.53s)
=== RUN   TestChangefeedEachColumnFamilySchemaChanges/sinkless
    helpers_test.go:872: making server as secondary tenant
    helpers_test.go:951: making sinkless feed factory
    helpers_test.go:1016: pgURL sinkless SinklessFeedUser
    helpers_test.go:1016: pgURL sinkless root
    testfeed_test.go:273: sinkless feed creating changefeed: CREATE CHANGEFEED FOR foo WITH split_column_families
    changefeed_test.go:3087: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:200
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:275
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:3087
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1123
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1158
        	Error:      	Received unexpected error:
        	            	expected message
        	            	(1) assertion failure
        	            	Wraps: (2) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.readNextMessages
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:120
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.assertPayloadsBaseErr
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:211
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.assertPayloadsBase.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:203
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.withTimeout.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:268
        	            	  | github.com/cockroachdb/cockroach/pkg/util/timeutil.RunWithTimeout
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/timeutil/timeout.go:33
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.withTimeout
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:264
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.assertPayloadsBase
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:201
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.assertPayloads
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:275
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.TestChangefeedEachColumnFamilySchemaChanges.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:3087
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamed.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1123
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamedWithSystem.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1158
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1689
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1695
        	            	Wraps: (3) expected message
        	            	Error types: (1) *assert.withAssertionFailure (2) *withstack.withStack (3) *errutil.leafError
        	Test:       	TestChangefeedEachColumnFamilySchemaChanges/sinkless
    testfeed_test.go:280: closing sinkless feed
    --- FAIL: TestChangefeedEachColumnFamilySchemaChanges/sinkless (15.52s)

Parameters:

  • attempt=1
  • race=true
  • run=2
  • shard=2
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-42038
@cockroach-teamcity cockroach-teamcity added branch-release-24.2.1-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc labels Sep 10, 2024
@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Sep 10, 2024
@andyyang890 andyyang890 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 10, 2024
@andyyang890 andyyang890 self-assigned this Sep 10, 2024
@andyyang890 andyyang890 added the P-2 Issues/test failures with a fix SLA of 3 months label Sep 17, 2024
@andyyang890 andyyang890 mentioned this issue Oct 2, 2024
Merged
craig bot pushed a commit that referenced this issue Oct 2, 2024
@cockroach-teamcity @andyyang890
Merge #131732 #131780
91d961f 
131732: ci: update bazel builder image r=rickystewart a=cockroach-teamcity

Release note: None
Epic: None


131780: changefeedccl: enable verbose logs for a few schema change unit tests r=rharding6373 a=andyyang890

**changefeedccl/kvfeed: add debug logs around schema change boundary types**

Release note: None

----

**changefeedccl: add debug logs around when processors move to draining**

Release note: None

----

**changefeedccl: enable verbose logs for a few schema change unit tests**

We're seeing that some changefeed unit tests involving schema changes
are sometimes flaking when using a core changefeed. This patch enables
verbose logs that will provide more information about what the kv feed
is doing when it sees the schema change and when processors are moving
to draining.

Release note: None

----

Informs #131186
Informs #130404
Informs #129777
Informs #129226
Informs #129045

Co-authored-by: cockroach-teamcity <[email protected]>
Co-authored-by: Andy Yang <[email protected]>
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2024
Merged
This was referenced Oct 3, 2024
Merged
Merged
Merged
@rharding6373
Copy link
Collaborator

Closing due to an old branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyyang890 andyyang890

Labels
A-cdc Change Data Capture branch-release-24.2.1-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-cdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rharding6373 @cockroach-teamcity @andyyang890