Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: import/mixed-versions failed #129211

Closed
cockroach-teamcity opened this issue Aug 19, 2024 · 7 comments · Fixed by #129775
Closed

roachtest: import/mixed-versions failed #129211

cockroach-teamcity opened this issue Aug 19, 2024 · 7 comments · Fixed by #129775
Assignees
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 19, 2024

roachtest.import/mixed-versions failed with artifacts on release-24.2 @ ad78dc73db84c9749fd5d8da982bab8030376251:

(mixedversion.go:694).Run: unexpected node event: n1: cockroach process for system interface died (exit code 134)
test artifacts and logs in: /artifacts/import/mixed-versions/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

This test on roachdash | Improve this report!

Jira issue: CRDB-41449

@cockroach-teamcity cockroach-teamcity added branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Aug 19, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Aug 19, 2024
@rytaft rytaft added the X-duplicate Closed as a duplicate of another issue. label Aug 21, 2024
@rytaft
Copy link
Collaborator

rytaft commented Aug 21, 2024

Dup of #127582

@rytaft rytaft closed this as completed Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Aug 21, 2024
@rytaft
Copy link
Collaborator

rytaft commented Aug 21, 2024

Just kidding, not a dup of that issue.

@rytaft rytaft reopened this Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Done to Triage in SQL Queries Aug 21, 2024
@rytaft rytaft removed the X-duplicate Closed as a duplicate of another issue. label Aug 21, 2024
@rytaft
Copy link
Collaborator

rytaft commented Aug 21, 2024

Looks like there was a panic on node 1:

I240819 05:54:58.089234 1 util/log/flags.go:213  [-] 1  stderr capture started
panic: unknown retry reason 8

goroutine 1763 [running]:
panic({0x5ae6b00?, 0xc012a61e30?})
	GOROOT/src/runtime/panic.go:1017 +0x3ac fp=0xc00d3218c0 sp=0xc00d321810 pc=0x49c36c
github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.rangeFeedErrorCounters.GetRangeFeedRetryCounter({0xc003ce5920, 0xc003ce5980, {0xc004007c80, 0x8, 0x8}, 0xc003ce59e0, 0xc003ce5a40, 0xc003ce5aa0, 0xc003ce5b00, 0xc003ce5b60, ...}, ...)
	github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender.go:427 +0x85 fp=0xc00d321910 sp=0xc00d3218c0 pc=0x1b92005
github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.handleRangefeedError({0x7778b48, 0xc0022fb090}, 0xc004aa03e8, {0x7729480, 0xc01738cfb4})
	github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:681 +0x398 fp=0xc00d321a20 sp=0xc00d321910 pc=0x1ba7398
github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).partialRangeFeed(0xc004aa0000, {0x7778b48, 0xc0022fb090}, 0xc002445520, {{0xc0012890e8, 0x3, 0x8}, {0xc0012890f0, 0x3, 0x8}}, ...)
	github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:605 +0x968 fp=0xc00d321e58 sp=0xc00d321a20 pc=0x1ba6be8
github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.1({0x7778b48?, 0xc0022fb090?})
	github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go:281 +0xf4 fp=0xc00d321f58 sp=0xc00d321e58 pc=0x1ba4a94
github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).RangeFeedSpans.func1.Group.GoCtx.func2()
	github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168 +0x22 fp=0xc00d321f78 sp=0xc00d321f58 pc=0x1ba4982
golang.org/x/sync/errgroup.(*Group).Go.func1()
	golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x56 fp=0xc00d321fe0 sp=0xc00d321f78 pc=0x1ad7716
runtime.goexit()
	src/runtime/asm_amd64.s:1650 +0x1 fp=0xc00d321fe8 sp=0xc00d321fe0 pc=0x4d2fc1
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 1679
	golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x96

@rytaft
Copy link
Collaborator

rytaft commented Aug 21, 2024

@msbutler looks related to #127029.

@rytaft rytaft added T-kv KV Team and removed T-sql-queries SQL Queries Team labels Aug 21, 2024
@rytaft rytaft removed this from SQL Queries Aug 21, 2024
@renatolabs
Copy link
Contributor

This is a dupe of #128057. The fix for this bug is not on any public release yet. This test seems much more prone than the others to hit this bug, so I'd recommend passing mixedversion.AlwaysUseLatestPredecessors to this test so that we stop seeing this bug when v24.1.4 is out.

@andrewbaptist andrewbaptist added T-sql-queries SQL Queries Team and removed T-kv KV Team labels Aug 23, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Aug 23, 2024
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
@DrewKimball DrewKimball moved this from Triage to Active in SQL Queries Aug 28, 2024
@DrewKimball DrewKimball self-assigned this Aug 28, 2024
@DrewKimball DrewKimball removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Aug 28, 2024
craig bot pushed a commit that referenced this issue Aug 28, 2024
129775: roachtest: use latest versions for mixed-version import test r=DrewKimball a=DrewKimball

Previously, the mixed import roachtest could use random versions of each release. This caused the test to flake due to #127029, so this commit prevents the flakes by making the test use the latest versions.

Fixes #129211

Release note: None

Co-authored-by: Drew Kimball <[email protected]>
@craig craig bot closed this as completed in bff1beb Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Incoming to Closed in KV Aug 28, 2024
Copy link

blathers-crl bot commented Aug 28, 2024

Based on the specified backports for linked PR #129775, I applied the following new label(s) to this issue: branch-release-23.2, branch-release-24.1. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 labels Aug 28, 2024
blathers-crl bot pushed a commit that referenced this issue Aug 28, 2024
Previously, the mixed import roachtest could use random versions of each
release. This caused the test to flake due to #127029, so this commit
prevents the flakes by making the test use the latest versions.

Fixes #129211

Release note: None
blathers-crl bot pushed a commit that referenced this issue Aug 28, 2024
Previously, the mixed import roachtest could use random versions of each
release. This caused the test to flake due to #127029, so this commit
prevents the flakes by making the test use the latest versions.

Fixes #129211

Release note: None
@rytaft
Copy link
Collaborator

rytaft commented Aug 28, 2024

This is a dupe of #128057. The fix for this bug is not on any public release yet. This test seems much more prone than the others to hit this bug, so I'd recommend passing mixedversion.AlwaysUseLatestPredecessors to this test so that we stop seeing this bug when v24.1.4 is out.

Thanks @renatolabs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
Archived in project
Status: Closed
Development

Successfully merging a pull request may close this issue.

5 participants