Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ccl/telemetryccl/telemetryccl_test: TestTelemetry failed #128045

Closed
cockroach-teamcity opened this issue Jul 31, 2024 · 6 comments · Fixed by #128383
Closed

pkg/ccl/telemetryccl/telemetryccl_test: TestTelemetry failed #128045

cockroach-teamcity opened this issue Jul 31, 2024 · 6 comments · Fixed by #128383
Assignees
@dhartunian
Labels
branch-master Failures and bugs on the master branch. branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 31, 2024 •
edited by cockroach-jira-scripts
Loading

pkg/ccl/telemetryccl/telemetryccl_test.TestTelemetry failed with artifacts on master @ 7afbca49760b34c2636971cdadf63e33aa23afdc:

        sql.plan.type.force-generic
    datadriven.go:144: 
        testdata/telemetry/generic:81:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:85:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:89:
        exec [0 args]
        SET plan_cache_mode = auto
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:94:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.auto-generic
    datadriven.go:144: 
        testdata/telemetry/generic:101:
        feature-usage [0 args]
        EXECUTE p_join(2)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:106:
        feature-usage [0 args]
        EXECUTE p_join(3)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:111:
        feature-usage [0 args]
        EXECUTE p_join(4)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:116:
         EXECUTE p_join(5)
        expected:
        sql.plan.type.auto-custom
        
        found:
        sql.plan.type.auto-custom
        sql.plan.type.force-custom
        --- FAIL: TestTelemetry/generic/server (0.67s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/obs-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-40769
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability labels Jul 31, 2024
@cockroach-teamcity
Copy link
Member Author

pkg/ccl/telemetryccl/telemetryccl_test.TestTelemetry failed on master @ 7a1bf52daa3f3dcaa434fd66d2b3c960a3c9c2a5:

        ----
    datadriven.go:144: 
        testdata/telemetry/generic:89:
        exec [0 args]
        SET plan_cache_mode = auto
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:94:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.auto-generic
    datadriven.go:144: 
        testdata/telemetry/generic:101:
        feature-usage [0 args]
        EXECUTE p_join(2)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:106:
        feature-usage [0 args]
        EXECUTE p_join(3)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:111:
        feature-usage [0 args]
        EXECUTE p_join(4)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:116:
        feature-usage [0 args]
        EXECUTE p_join(5)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:122:
        feature-usage [0 args]
        EXECUTE p_join(6)
        ----
        sql.plan.type.auto-generic
    datadriven.go:144: 
        testdata/telemetry/generic:128:
         SELECT * FROM kv WHERE v = 100
        expected:
        
        found:
        sql.plan.type.force-custom
        --- FAIL: TestTelemetry/generic/server (1.00s)

Parameters:

  • attempt=1
  • run=6
  • shard=3
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 2, 2024
Closed
@cockroach-teamcity
Copy link
Member Author

pkg/ccl/telemetryccl/telemetryccl_test.TestTelemetry failed on master @ 78fa126dfc749e620c28531c1659e35bf98034ec:

    datadriven.go:144: 
        testdata/telemetry/generic:66:
        exec [0 args]
        SET plan_cache_mode = force_generic_plan
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:70:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.force-generic
    datadriven.go:144: 
        testdata/telemetry/generic:75:
        feature-usage [0 args]
        EXECUTE p_join(0)
        ----
        sql.plan.type.force-generic
    datadriven.go:144: 
        testdata/telemetry/generic:81:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:85:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:89:
        exec [0 args]
        SET plan_cache_mode = auto
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:94:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.auto-generic
    datadriven.go:144: 
        testdata/telemetry/generic:101:
         EXECUTE p_join(2)
        expected:
        sql.plan.type.auto-custom
        
        found:
        sql.plan.type.auto-custom
        sql.plan.type.force-custom
        --- FAIL: TestTelemetry/generic/server (0.44s)
=== RUN   TestTelemetry/generic
    --- FAIL: TestTelemetry/generic (6.38s)

Parameters:

  • attempt=1
  • run=13
  • shard=3
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

pkg/ccl/telemetryccl/telemetryccl_test.TestTelemetry failed with artifacts on master @ 6ae5e64c3ddc3a0e1bbb304f2930f0bbdc184d86:

        SELECT * FROM kv WHERE k = $1
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:24:
        exec [0 args]
        PREPARE p_join AS
        SELECT * FROM kv
        JOIN ab ON a = k
        WHERE v = $1
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:31:
        feature-list [0 args]
        sql.plan.type.*
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:35:
        exec [0 args]
        SET plan_cache_mode = force_custom_plan
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:39:
        exec [0 args]
        SET index_recommendations_enabled = false
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:43:
        exec [0 args]
        SET application_name = 'testuser'
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:47:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.force-custom
    datadriven.go:144: 
        testdata/telemetry/generic:52:
        feature-usage [0 args]
        EXECUTE p_join(1)
        ----
        sql.plan.type.force-custom
    datadriven.go:144: 
        testdata/telemetry/generic:58:
         SELECT * FROM kv WHERE v = 100
        expected:
        
        found:
        sql.plan.type.force-custom
        --- FAIL: TestTelemetry/generic/server (0.09s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

pkg/ccl/telemetryccl/telemetryccl_test.TestTelemetry failed on master @ 356e1cc24a67d7e9a1e637b98d1664794f70fa03:

    datadriven.go:144: 
        testdata/telemetry/generic:85:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:89:
        exec [0 args]
        SET plan_cache_mode = auto
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:94:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.auto-generic
    datadriven.go:144: 
        testdata/telemetry/generic:101:
        feature-usage [0 args]
        EXECUTE p_join(2)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:106:
        feature-usage [0 args]
        EXECUTE p_join(3)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:111:
        feature-usage [0 args]
        EXECUTE p_join(4)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:116:
        feature-usage [0 args]
        EXECUTE p_join(5)
        ----
        sql.plan.type.auto-custom
    datadriven.go:144: 
        testdata/telemetry/generic:122:
         EXECUTE p_join(6)
        expected:
        sql.plan.type.auto-generic
        
        found:
        sql.plan.type.auto-generic
        sql.plan.type.force-custom
        --- FAIL: TestTelemetry/generic/server (0.41s)

Parameters:

  • attempt=1
  • run=14
  • shard=3
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@dhartunian dhartunian self-assigned this Aug 5, 2024
@dhartunian dhartunian added the P-1 Issues/test failures with a fix SLA of 1 month label Aug 5, 2024
@dhartunian dhartunian mentioned this issue Aug 6, 2024
Merged
@cockroach-teamcity
Copy link
Member Author

pkg/ccl/telemetryccl/telemetryccl_test.TestTelemetry failed with artifacts on master @ 7917e91eadb2f622faadf635a3e13c384e42070e:

        exec [0 args]
        SET plan_cache_mode = force_custom_plan
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:39:
        exec [0 args]
        SET index_recommendations_enabled = false
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:43:
        exec [0 args]
        SET application_name = 'testuser'
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:47:
        feature-usage [0 args]
        EXECUTE p_pk(100)
        ----
        sql.plan.type.force-custom
    datadriven.go:144: 
        testdata/telemetry/generic:52:
        feature-usage [0 args]
        EXECUTE p_join(1)
        ----
        sql.plan.type.force-custom
    datadriven.go:144: 
        testdata/telemetry/generic:58:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:62:
        feature-usage [0 args]
        SELECT * FROM kv WHERE v = 100
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:66:
        exec [0 args]
        SET plan_cache_mode = force_generic_plan
        ----
    datadriven.go:144: 
        testdata/telemetry/generic:70:
         EXECUTE p_pk(100)
        expected:
        sql.plan.type.force-generic
        
        found:
        sql.plan.type.force-custom
        sql.plan.type.force-generic
        --- FAIL: TestTelemetry/generic/server (0.15s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Aug 7, 2024
@annrpom @dhartunian
Merge #127865 #128383
fd17117 
127865: jobs: ignore schemachange gc during validation r=rafiss a=annrpom

During our validation of jobs, we do not need to consider
SchemaChangeGC jobs as a cause of failing validation.
If these GC jobs are running, we can assume
that the descriptor will eventually get gc'ed.
In a pause or pause requested state, once the job is
allowed to run again, descriptors will eventually get gc'ed.
SchemaChangeGC jobs with invalid descriptor references
likely means that the GC job has already progressed.

Since this information is still useful, we continue logging
these messages to stdout.

Epic: none

Fixes: #126374
Release note: None

128383: telemetry: deflake generic query plan telemetry test r=mgartner a=dhartunian

Narrowed down scope of counter filters in order to not catch stray increment events from background queries.

Resolves: #128045, #128171

Release note: None

Co-authored-by: Annie Pompa <[email protected]>
Co-authored-by: David Hartunian <[email protected]>
@craig craig bot closed this as completed in 02983b4 Aug 7, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Aug 7, 2024

Based on the specified backports for linked PR #128383, I applied the following new label(s) to this issue: branch-release-24.1, branch-release-24.2. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 labels Aug 7, 2024
blathers-crl bot pushed a commit that referenced this issue Aug 7, 2024
@dhartunian
telemetry: deflake generic query plan telemetry test
1f24839 
Narrowed down scope of counter filters in order to not catch stray
increment events from background queries.

Resolves: #128045, #128171

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Aug 7, 2024
Merged
dhartunian added a commit to dhartunian/cockroach that referenced this issue Aug 16, 2024
@dhartunian
telemetry: deflake generic query plan telemetry test
d19e547 
Narrowed down scope of counter filters in order to not catch stray
increment events from background queries.

Resolves: cockroachdb#128045, cockroachdb#128171

Release note: None
kyle-a-wong pushed a commit to kyle-a-wong/cockroach that referenced this issue Sep 17, 2024
@dhartunian @kyle-a-wong
telemetry: deflake generic query plan telemetry test
d14b328 
Narrowed down scope of counter filters in order to not catch stray
increment events from background queries.

Resolves: cockroachdb#128045, cockroachdb#128171

Release note: None
kyle-a-wong pushed a commit to kyle-a-wong/cockroach that referenced this issue Sep 17, 2024
@dhartunian @kyle-a-wong
telemetry: deflake generic query plan telemetry test
1eb5a95 
Narrowed down scope of counter filters in order to not catch stray
increment events from background queries.

Resolves: cockroachdb#128045, cockroachdb#128171

Release note: None
kyle-a-wong pushed a commit that referenced this issue Sep 17, 2024
@dhartunian @kyle-a-wong
telemetry: deflake generic query plan telemetry test
1534665 
Narrowed down scope of counter filters in order to not catch stray
increment events from background queries.

Resolves: #128045, #128171

Release note: None
kyle-a-wong pushed a commit that referenced this issue Sep 17, 2024
@dhartunian @kyle-a-wong
telemetry: deflake generic query plan telemetry test
dfa9ba5 
Narrowed down scope of counter filters in order to not catch stray
increment events from background queries.

Resolves: #128045, #128171

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhartunian dhartunian

Labels
branch-master Failures and bugs on the master branch. branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

telemetry: deflake generic query plan telemetry test dhartunian/cockroach
2 participants
@dhartunian @cockroach-teamcity