-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workload/schemachange: handle crdb_internal computed cols in colIsRefByComputed #126967
Labels
C-test-failure
Broken test (automatically or manually discovered).
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
annrpom
added
C-test-failure
Broken test (automatically or manually discovered).
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
labels
Jul 10, 2024
From Faizan:
|
exalate-issue-sync
bot
added
the
P-2
Issues/test failures with a fix SLA of 3 months
label
Jul 30, 2024
Let's fix this as part of enabling DROP COLUMN (#127286): cockroach/pkg/workload/schemachange/operation_generator.go Lines 1631 to 1635 in e77f714
|
craig bot
pushed a commit
that referenced
this issue
Oct 4, 2024
131797: workload/schemachanger: address flakes and stabilize this test r=fqazi a=fqazi This patch will address the following flakes: 1. Allow constraint violations on add column / alter pk, since concurrent inserts can cause these errors on commit 2. Fix aborted txn error inside ADD FOREIGN KEY, which was because one of the intropection queries was never run inside a child txn. 3. Address command is too large error in insert, which could cause inserts to fail when a large number of columns existed on a table. 4. Address a bug inside INSERT foreign key validation when multiple rows were inserted in the same batch 5. Handle crdb_internal computed cols in colIsRefByComputed, which removes a potential error from DROP COLUMN Fixes: #131345 Fixes: #130923 Fixes: #126967 131845: kvserver: deflake TestNewRangefeedForceLeaseRetry r=iskettaneh a=iskettaneh This commit lets the test waits for N1's view of N2's lease expiration to match N2's view. This is important in the rare case where N1 tries to increase N2's epoch, but it has a stale view of the lease expiration time. Fixes: #131808 Release note: None 131905: cli: add --user flag to client cmds r=tbg a=tbg I originally sent #130827 in reaction to finding that `./cockroach gen haproxy` didn't work with SQL urls that used client certs for a non-root user (it would erroneously expect to be pointed at the root client certs). That PR caused problems too; now one needed to specify `--certs` even though the certs were in the URL. There's a fix for that too (#131894) but it all seems pretty tangled up. This PR takes a more straightforward route: we revert #130827 and add the `--user` flag to all client commands (who all already get the `--sql` flag. This should have fewer unintended consequences, and solves the problem. Fixes #131802. Fixes #131812. Fixes #131814. Fixes #131815. Fixes #131816. Fixes #131817. Epic: none Release note: None Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Ibrahim Kettaneh <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-test-failure
Broken test (automatically or manually discovered).
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Our query for colIsRefByComputed cannot handle the following case (human-readable ops generated by schemachange workload):
Jira issue: CRDB-40208
Epic CRDB-19168
The text was updated successfully, but these errors were encountered: