Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the loading state(s) of the Databases page #124153

Closed
kevin-v-ngo opened this issue May 14, 2024 · 0 comments · Fixed by #127075
Closed

Update the loading state(s) of the Databases page #124153

kevin-v-ngo opened this issue May 14, 2024 · 0 comments · Fixed by #127075
Assignees
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months T-observability

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented May 14, 2024

The console sends several requests to populate the Databases page with information (e.g., number of tables, sizes, etc.) which take noticeable time to complete. The loading state of this information is confusing where we surface 'Unavailable'.

We should be clear, consistent, and conform to our design library for loading states.

Slack thread context and figma

Jira issue: CRDB-38732

Epic CRDB-37558

@kevin-v-ngo kevin-v-ngo added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability labels May 14, 2024
@kevin-v-ngo kevin-v-ngo added the O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs label Jun 13, 2024
@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Jun 18, 2024
@dhartunian dhartunian added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 labels Jul 8, 2024
dhartunian added a commit to dhartunian/cockroach that referenced this issue Jul 12, 2024
The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: cockroachdb#124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.
craig bot pushed a commit that referenced this issue Jul 19, 2024
127075: ui: add loading skeletons to databases and tables pages r=xinhaoz a=dhartunian

The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: #124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.

127428: crosscluster/logical: set UDF function name from SQL input r=dt a=stevendanna

First commit is #127024

See individual commits.

Co-authored-by: David Hartunian <[email protected]>
Co-authored-by: Steven Danna <[email protected]>
@craig craig bot closed this as completed in b903f8f Jul 19, 2024
dhartunian added a commit to dhartunian/cockroach that referenced this issue Jul 25, 2024
The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

We add styling to ensure that warning icons within cells are aligned
properly and colored the orange color we use elsewhere.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: cockroachdb#124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.
dhartunian added a commit to dhartunian/cockroach that referenced this issue Jul 25, 2024
The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

We add styling to ensure that warning icons within cells are aligned
properly and colored the orange color we use elsewhere.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: cockroachdb#124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.
dhartunian added a commit to dhartunian/cockroach that referenced this issue Jul 26, 2024
The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

We add styling to ensure that warning icons within cells are aligned
properly and colored the orange color we use elsewhere.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: cockroachdb#124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.
dhartunian added a commit to dhartunian/cockroach that referenced this issue Jul 26, 2024
The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

We add styling to ensure that warning icons within cells are aligned
properly and colored the orange color we use elsewhere.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: cockroachdb#124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.
DarrylWong pushed a commit to DarrylWong/fork that referenced this issue Jul 31, 2024
The databases and tables pages can take a long time to load data on
clusters with large sizes. The current user experience did not clearly
signal which pieces of information were in progress or missing. This
change updates each cell to show a skeleton as it waits for data from
the backend. If there's no data returned we will show the text "No
Data" instead of "(unavailable)".

The `checkInfoAvailable` helper function is converted into a
functional React component for ease of testing and code uniformity.

We add styling to ensure that warning icons within cells are aligned
properly and colored the orange color we use elsewhere.

Also removes the narrow styling of the "% of Live Data" column.

Resolves: cockroachdb#124153
Epic: CRDB-37558

Release note (ui change): The databases and tables pages in the DB
Console will show a loading state while loading information for
databases and tables including size and range counts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-2 Issues/test failures with a fix SLA of 3 months T-observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants