-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogicCCL_cluster_locks_tenant failed #121401
Comments
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_cluster_locks_tenant failed with artifacts on master @ 7fc4c7bcbbf0c75a62d056da0bf79a5a32714650:
Same failure on other branches
|
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_cluster_locks_tenant failed on master @ 7fc4c7bcbbf0c75a62d056da0bf79a5a32714650:
Parameters:
Same failure on other branches
|
This is the same as #120821, so #121052 didn't fix this, cc @nvanbenschoten |
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_cluster_locks_tenant failed on master @ c43f54cdde5b7578f4a0ca61de41463f0d690993:
Parameters:
|
Could this potentially be the same issue as #120931 @arulajmani? |
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_cluster_locks_tenant failed on master @ 7166724ff02b9b7f0d5787f74d919487ca347bd0:
Parameters:
|
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_cluster_locks_tenant failed on master @ 0d3c5b71415de867fedde97de01486d424209848:
Parameters:
|
cc @nvanbenschoten, this is the issue I mentioned during our meeting. |
I wonder if that change is playing poorly with the use of |
I believe the change in behavior here from:
to
can be traced back to enabling pipelining for DeleteRange requests. This trips up the DELETE statement here. |
121857: sql: run tenant logic tests with manual replication mode r=nvanbenschoten a=nvanbenschoten Fixes #121401. This commit removes the use of automatic replication mode for secondary tenant SQL logic tests, so that the configuration more closely matches that for single tenant SQL logic tests. In doing so, it eliminates some of the recent flakiness which has come from 3d87bec, where ranges now split and rebalance much more often for secondary tenants. To accomplish this, the commit updates the `distsql_tenant_locality` tests to manually upreplicate. The commit also needed to fix up `cluster_locks_tenant`, which was broken by #99735. Now that we're running with manual replication mode, we can't rely on a range split or lease transfer to clear unreplicated locks, which was undermining the point of the test anyway. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Fixes #121401. This commit removes the use of automatic replication mode for secondary tenant SQL logic tests, so that the configuration more closely matches that for single tenant SQL logic tests. In doing so, it eliminates some of the recent flakiness which has come from 3d87bec, where ranges now split and rebalance much more often for secondary tenants. To accomplish this, the commit updates the `distsql_tenant_locality` tests to manually upreplicate. The commit also needed to fix up `cluster_locks_tenant`, which was broken by #99735. Now that we're running with manual replication mode, we can't rely on a range split or lease transfer to clear unreplicated locks, which was undermining the point of the test anyway. Release note: None
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_cluster_locks_tenant failed with artifacts on master @ 2a5e231716c436781f12452d800651f51c6383b7:
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-37224
The text was updated successfully, but these errors were encountered: