Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: treat memory monitor errors as retriable #120807

Closed
fqazi opened this issue Mar 21, 2024 · 0 comments · Fixed by #120806
Closed

sql: treat memory monitor errors as retriable #120807

fqazi opened this issue Mar 21, 2024 · 0 comments · Fixed by #120806
Assignees
@fqazi
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@fqazi
Copy link
Collaborator

fqazi commented Mar 21, 2024 •
edited by exalate-issue-sync bot
Loading

Previously, if a memory or disk error was hit during a backfill it was treated as a permanent failure, but these should be treated as transient retryable / transient errors. Reverting the entire schema change might be extreme if there is any transient issue on the cluster.
@fqazi fqazi added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 21, 2024
@fqazi fqazi self-assigned this Mar 21, 2024
@fqazi fqazi mentioned this issue Mar 21, 2024
Merged
@fqazi fqazi added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Mar 21, 2024
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Mar 21, 2024
fqazi pushed a commit to fqazi/cockroach that referenced this issue Mar 21, 2024
@ajwerner @fqazi
sql: treat memory monitor errors as retriable
8dc92b1 
Release note (bug fix): Memory exhaustion errors which can occur during schema
changes are no longer considered to be permanent failures. These schema changes
will now be retried rather than reverted.

Fixes: cockroachdb#120807
fqazi pushed a commit to fqazi/cockroach that referenced this issue Mar 22, 2024
@ajwerner @fqazi
sql: treat memory monitor errors as retriable
2b87b92 
Release note (bug fix): Memory exhaustion errors which can occur during schema
changes are no longer considered to be permanent failures. These schema changes
will now be retried rather than reverted.

Fixes: cockroachdb#120807
craig bot pushed a commit that referenced this issue Mar 22, 2024
@ajwerner
Merge #120806
620aa02 
120806: sql: treat memory monitor errors as retriable r=fqazi a=fqazi

Release note (bug fix): Memory exhaustion errors which can occur during schema changes are no longer considered to be permanent failures. These schema changes will now be retried rather than reverted.

This is just rebase of a PR by `@ajwerner:` #71816, with a minor change to improve test reliability.

Fixes: #120807

Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in f280d53 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
No open projects
SQL Foundations
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: treat memory monitor errors as retriable fqazi/cockroach
1 participant
@fqazi