kvserver: disallow remote AddSSTable for non-system tenants #120525
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
GA-blocker
P-0
Issues/test failures with a fix SLA of 2 weeks
T-disaster-recovery
Comments
dt
added
C-bug
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Hi @dt, please add branch-* labels to identify which branch(es) this GA-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
cc @cockroachdb/disaster-recovery |
|
This should probably wait for #120526 since it'll be trivial then. |
|
cc @cockroachdb/disaster-recovery |
exalate-issue-sync
bot
added
the
P-0
craig bot
pushed a commit
that referenced
this issue
Mar 25, 2024
121028: kvcoord: don't untrip DistSender circuit breaker on shutdown r=erikgrinaker a=erikgrinaker Previously, if the node shuts down while a circuit breaker probe is in flight, this could cause the breaker to untrip. It shouldn't. Epic: none Release note: None 121029: kvcoord: use single threshold to GC DistSender circuit breakers r=erikgrinaker a=erikgrinaker This patch uses a common idle timeout to GC both tripped and untripped circuit breakers, and increases the timeout to 20 minutes. Epic: none Release note: None 121031: backupccl: disable link external sst requests from seperate process non system tenants r=dt a=msbutler Fixes #120525 Release note: none Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Michael Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A remote AddSSTable request can cause kvserver instability so we should not allow them except from the system tenant and shared service secondary tenants.
Jira issue: CRDB-36730
The text was updated successfully, but these errors were encountered: