Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvnemesis: TestKVNemesisSingleNode_ReproposalChaos failed #117855

Closed
cockroach-teamcity opened this issue Jan 17, 2024 · 2 comments · Fixed by #117864
Closed

kv/kvnemesis: TestKVNemesisSingleNode_ReproposalChaos failed #117855

cockroach-teamcity opened this issue Jan 17, 2024 · 2 comments · Fixed by #117864
Assignees
@arulajmani
Labels
A-kv-transactions Relating to MVCC and the transactional model. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 17, 2024 •
edited by cockroach-jira-scripts
Loading

kv/kvnemesis.TestKVNemesisSingleNode_ReproposalChaos failed on master @ 1898adc059e9b3026fd5a7ed88dc41cbb006abfc:

F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !goroutine 6503 [select]:
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker.func1()
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:171 +0xcb
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !created by github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker in goroutine 6469
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:166 +0x58
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !goroutine 6495 [select]:
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !github.com/cockroachdb/cockroach/pkg/util/admission.initWorkQueue.func2()
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/cockroach/pkg/util/admission/work_queue.go:425 +0x85
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !created by github.com/cockroachdb/cockroach/pkg/util/admission.initWorkQueue in goroutine 6469
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/cockroach/pkg/util/admission/work_queue.go:422 +0x3ce
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !goroutine 8547 [sync.Cond.Wait]:
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !sync.runtime_notifyListWait(0xc0065680a0, 0x8)
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	GOROOT/src/runtime/sema.go:527 +0x159
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !sync.(*Cond).Wait(0xc161fccf408b4271?)
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	GOROOT/src/sync/cond.go:70 +0x85
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !github.com/cockroachdb/pebble/record.(*flusherCond).Wait(...)
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/pebble/record/external/com_github_cockroachdb_pebble/record/log_writer.go:204
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !github.com/cockroachdb/pebble/record.(*LogWriter).flushLoop(0xc006568000, {0x4a518e0, 0xa966040})
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/pebble/record/external/com_github_cockroachdb_pebble/record/log_writer.go:438 +0x67c
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !runtime/pprof.Do({0x719b458?, 0xa966040?}, {{0xc000c79e80?, 0xc0063b1230?, 0x0?}}, 0xc004ceafc0)
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	GOROOT/src/runtime/pprof/runtime.go:51 +0x9d
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !github.com/cockroachdb/pebble/record.NewLogWriter.func2()
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/pebble/record/external/com_github_cockroachdb_pebble/record/log_writer.go:357 +0x56
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !created by github.com/cockroachdb/pebble/record.NewLogWriter in goroutine 6469
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !	github.com/cockroachdb/pebble/record/external/com_github_cockroachdb_pebble/record/log_writer.go:356 +0x416
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !For more context, check log files in: /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/testlogs/pkg/kv/kvnemesis/kvnemesis_test/run_23_of_30/test.outputs/logTestKVNemesisSingleNode_ReproposalChaos2618661357
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !****************************************************************************
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !This node experienced a fatal error (printed above), and as a result the
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !process is terminating.
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !Fatal errors can occur due to faulty hardware (disks, memory, clocks) or a
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !problem in CockroachDB. With your help, the support team at Cockroach Labs
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !will try to determine the root cause, recommend next steps, and we can
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !improve CockroachDB based on your report.
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !Please submit a crash report by following the instructions here:
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !    https://github.com/cockroachdb/cockroach/issues/new/choose
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !If you would rather not post publicly, please contact us directly at:
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !    [email protected]
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !
F240117 07:03:30.090560 6469 storage/pebble.go:1621  [n1,s1,pebble] 1 !The Cockroach Labs team appreciates your feedback.

Parameters:

  • attempt=1
  • run=23
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/kv

This test on roachdash | Improve this report!

Jira issue: CRDB-35390
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Jan 17, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Jan 17, 2024
@cockroach-teamcity
Copy link
Member Author

kv/kvnemesis.TestKVNemesisSingleNode_ReproposalChaos failed with artifacts on master @ 1898adc059e9b3026fd5a7ed88dc41cbb006abfc:

        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).SendWithWriteBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_send.go:185
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).SendWithWriteBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/store_send.go:193
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Stores).SendWithWriteBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/stores.go:202
        	            	  | github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal
        	            	  | 	github.com/cockroachdb/cockroach/pkg/server/node.go:1374
        	            	  | github.com/cockroachdb/cockroach/pkg/server.(*Node).Batch
        	            	  | 	github.com/cockroachdb/cockroach/pkg/server/node.go:1508
        	            	  | github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/rpc/pkg/rpc/context.go:704
        	            	  | github.com/cockroachdb/cockroach/pkg/rpc.NewServerEx.ServerInterceptor.func12
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/tracing/grpcinterceptor/grpc_interceptor.go:97
        	            	Wraps: (2) secondary error attachment
        	            	  | runtime error: invalid memory address or nil pointer dereference
        	            	  | (1) runtime error: invalid memory address or nil pointer dereference
        	            	  | Error types: (1) runtime.errorString
        	            	Wraps: (3) panic applying step 
        	            	  | db0.Txn(ctx, func(ctx context.Context, txn *kv.Txn) error {
        	            	  |   txn.SetIsoLevel(isolation.Snapshot)
        	            	  |   txn.Del(ctx, tk(5249696758006338191) /* @s16 */) // @1705475864.224840051,0 <nil>
        	            	  |   txn.CreateSavepoint(ctx, 1) // <nil>
        	            	  |   txn.ReverseScanForUpdateSkipLockedGuaranteedDurability(ctx, tk(5266273772315040022), tk(11655896440274215750), 0) // @1705475865.961766566,2 <nil>
        	            	  |   txn.Get(ctx, tk(5249696758006338191)) // @1705475865.961766566,2 (<nil>, <nil>)
        	            	  |   txn.ReverseScanForShareSkipLocked(ctx, tk(360619043573631929), tk(11639319520741214964), 0)
        	            	  |   txn.ReverseScanForShareSkipLockedGuaranteedDurability(ctx, tk(5026726489439218541), tk(14652472971959553808), 0) // @1705475863.950370533,0 <nil>
        	            	  |   txn.GetForShareSkipLocked(ctx, tk(8863446001153500009)) // @1705475863.950370533,0 (<nil>, <nil>)
        	            	  |   txn.GetForUpdateSkipLockedGuaranteedDurability(ctx, tk(17848093743824365094)) // @1705475863.950370533,0 (<nil>, <nil>)
        	            	  |   txn.Get(ctx, tk(574545114681662749)) // @1705475863.950370533,0 (<nil>, <nil>)
        	            	  |   txn.ScanForShare(ctx, tk(2388423199798602576), tk(7012787110718562072), 0) // @1705475863.950370533,0 <nil>
        	            	  |   {
        	            	  |     b := &kv.Batch{}
        	            	  |     b.ScanForUpdateGuaranteedDurability(tk(1512180020284348694), tk(11548228960597482585)) // TransactionRetryWithProtoRefreshError: TransactionAbortedError(ABORT_REASON_PUSHER_ABORTED): "unnamed" meta={id=06cb0f2c key=/Table/100/"48daab63277cd28f" iso=Snapshot pri=0.00322778 epo=0 ts=1705475863.950370533,0 min=1705475863.950370533,0 seq=1} lock=true stat=ABORTED rts=1705475863.950370533,0 wto=false gul=1705475863.960370533,0
        	            	  |     txn.Run(ctx, b) // TransactionRetryWithProtoRefreshError: TransactionAbortedError(ABORT_REASON_PUSHER_ABORTED): "unnamed" meta={id=06cb0f2c key=/Table/100/"48daab63277cd28f" iso=Snapshot pri=0.00322778 epo=0 ts=1705475863.950370533,0 min=1705475863.950370533,0 seq=1} lock=true stat=ABORTED rts=1705475863.950370533,0 wto=false gul=1705475863.960370533,0
        	            	  |   }
        	            	  |   txn.Del(ctx, tk(574545114681662749) /* @s17 */) // omitted
        	            	  |   txn.ReverseScanForShare(ctx, tk(3878896557062979857), tk(10326966827668403221), 0) // omitted
        	            	  |   txn.GetForShareSkipLockedGuaranteedDurability(ctx, tk(9644533840137005473)) // omitted
        	            	  |   txn.Del(ctx, tk(10103755076387903579) /* @s18 */) // omitted
        	            	  |   txn.Put(ctx, tk(7085146436609535517), sv(19)) // omitted
        	            	  |   txn.ReverseScanForShare(ctx, tk(9480707471692331625), tk(11820767539718818062), 0) // omitted
        	            	  |   txn.ReverseScanForUpdateSkipLockedGuaranteedDurability(ctx, tk(16096764233863533895), tk(17384059814156811229), 0) // omitted
        	            	  |   txn.ReverseScanForShareSkipLockedGuaranteedDurability(ctx, tk(177212216442375237), tk(7321813812329985408), 0) // omitted
        	            	  |   return nil
        	            	  | }): runtime error: invalid memory address or nil pointer dereference
        	            	Error types: (1) *withstack.withStack (2) *secondary.withSecondaryError (3) *errutil.leafError
    panic.go:523: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/1f42cf5be2fc021646bf9b2daf5eaef3/logTestKVNemesisSingleNode_ReproposalChaos2308577468
--- FAIL: TestKVNemesisSingleNode_ReproposalChaos (8.40s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@erikgrinaker
Copy link
Contributor

Looks like a lock table issue, cc @arulajmani.

        	Error Trace:	github.com/cockroachdb/cockroach/pkg/kv/kvnemesis/pkg/kv/kvnemesis/kvnemesis_test.go:363
        	            				github.com/cockroachdb/cockroach/pkg/kv/kvnemesis/pkg/kv/kvnemesis/kvnemesis_test.go:274
        	Error:      	Received unexpected error:
        	            	panic applying step 
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvnemesis.(*Applier).Apply.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvnemesis/pkg/kv/kvnemesis/applier.go:68
        	            	  | runtime.gopanic
        	            	  | 	GOROOT/src/runtime/panic.go:914
        	            	  | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).recover
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:230
        	            	  | runtime.gopanic
        	            	  | 	GOROOT/src/runtime/panic.go:914
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).SendWithWriteBytes.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/store_send.go:109
        	            	  | runtime.gopanic
        	            	  | 	GOROOT/src/runtime/panic.go:920
        	            	  | runtime.panicmem
        	            	  | 	GOROOT/src/runtime/panic.go:261
        	            	  | runtime.sigpanic
        	            	  | 	GOROOT/src/runtime/signal_unix.go:861
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency.(*lockTableGuardImpl).isSameTxn
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency/lock_table.go:804
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency.(*lockTableGuardImpl).IsKeyLockedByConflictingTxn
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency/lock_table.go:749
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency.(*Guard).IsKeyLockedByConflictingTxn
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency/concurrency_manager.go:809
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver/batcheval.(*requestBoundLockTableView).IsKeyLockedByConflictingTxn
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/batcheval/lock.go:255
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.(*pebbleMVCCScanner).isKeyLockedByConflictingTxn
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/pebble_mvcc_scanner.go:1807
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.(*pebbleMVCCScanner).add
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/pebble_mvcc_scanner.go:1236
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.(*pebbleMVCCScanner).getOne
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/pebble_mvcc_scanner.go:827
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.(*pebbleMVCCScanner).scan
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/pebble_mvcc_scanner.go:658
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.mvccScanToBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/mvcc.go:4435
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.mvccScanToKvs
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/mvcc.go:4488
        	            	  | github.com/cockroachdb/cockroach/pkg/storage.MVCCScan
        	            	  | 	github.com/cockroachdb/cockroach/pkg/storage/mvcc.go:4733
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver/batcheval.ReverseScan
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/batcheval/cmd_reverse_scan.go:89
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.evaluateCommand
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_evaluate.go:488
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.evaluateBatch
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_evaluate.go:305
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).executeReadOnlyBatchWithServersideRefreshes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_read.go:473
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).executeReadOnlyBatch
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_read.go:135
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).executeBatchWithConcurrencyRetries
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_send.go:512
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).SendWithWriteBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/replica_send.go:185
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).SendWithWriteBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/store_send.go:193
        	            	  | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Stores).SendWithWriteBytes
        	            	  | 	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/stores.go:202
        	            	  | github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal
        	            	  | 	github.com/cockroachdb/cockroach/pkg/server/node.go:1374
        	            	  | github.com/cockroachdb/cockroach/pkg/server.(*Node).Batch
        	            	  | 	github.com/cockroachdb/cockroach/pkg/server/node.go:1508
        	            	  | github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/rpc/pkg/rpc/context.go:704
        	            	  | github.com/cockroachdb/cockroach/pkg/rpc.NewServerEx.ServerInterceptor.func12
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/tracing/grpcinterceptor/grpc_interceptor.go:97
        	            	Wraps: (2) secondary error attachment
        	            	  | runtime error: invalid memory address or nil pointer dereference
        	            	  | (1) runtime error: invalid memory address or nil pointer dereference
        	            	  | Error types: (1) runtime.errorString
        	            	Wraps: (3) panic applying step 
        	            	  | db0.Txn(ctx, func(ctx context.Context, txn *kv.Txn) error {
        	            	  |   txn.SetIsoLevel(isolation.Snapshot)
        	            	  |   txn.GetForUpdate(ctx, tk(2954581848373496430)) // @1705475860.684367306,0 (<nil>, <nil>)
        	            	  |   txn.GetForShare(ctx, tk(574545114681662749)) // @1705475860.684367306,0 (v9, <nil>)
        	            	  |   txn.ReverseScanForShareSkipLocked(ctx, tk(1820498217220570453), tk(7831833396965981956), 0)
        	            	  |   txn.ScanForUpdate(ctx, tk(10391090840890742608), tk(14359564960357966375), 0)
        	            	  |   txn.ReverseScanForUpdate(ctx, tk(7224580107135627516), tk(13038096599029329166), 0)
        	            	  |   txn.GetForShareGuaranteedDurability(ctx, tk(12530610722970564363))
        	            	  |   txn.ScanForShare(ctx, tk(7262151861797917607), tk(18430215113825785752), 0)
        	            	  |   return errors.New("rollback")
        	            	  | }): runtime error: invalid memory address or nil pointer dereference
        	            	Error types: (1) *withstack.withStack (2) *secondary.withSecondaryError (3) *errutil.leafError

@erikgrinaker erikgrinaker mentioned this issue Jan 17, 2024
Closed
@arulajmani arulajmani self-assigned this Jan 17, 2024
@arulajmani arulajmani mentioned this issue Jan 17, 2024
Merged
craig bot pushed a commit that referenced this issue Jan 17, 2024
@miraradeva @arulajmani
Merge #117326 #117864
9b10f08 
117326: kvnemesis: add support for non-voting replicas r=kvoli a=miraradeva

This change extends the ChangeReplicas config in kvnemesis to include adding, removing and promoting non-voting replicas, as well as demoting voting replicas.

Fixes: #59060

Release note: None

117864: concurrency: prevent panic in IsKeyLockedByConflictingTxn r=arulajmani a=arulajmani

This was missing a nil check.

Closes #117855
Closes #117854

Release note: None

Co-authored-by: Mira Radeva <[email protected]>
Co-authored-by: Arul Ajmani <[email protected]>
@craig craig bot closed this as completed in 20046d3 Jan 17, 2024
@arulajmani arulajmani added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-transactions Relating to MVCC and the transactional model. labels Jan 17, 2024
@github-project-automation github-project-automation bot moved this to Closed in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
A-kv-transactions Relating to MVCC and the transactional model. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team
Projects
No open projects
KV
Status: Closed
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

concurrency: prevent panic in IsKeyLockedByConflictingTxn arulajmani/cockroach
3 participants
@erikgrinaker @arulajmani @cockroach-teamcity