Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: backup/KMS/AWS/n3cpu4 failed #116426

Closed
cockroach-teamcity opened this issue Dec 14, 2023 · 2 comments · Fixed by #116437
Closed

roachtest: backup/KMS/AWS/n3cpu4 failed #116426

cockroach-teamcity opened this issue Dec 14, 2023 · 2 comments · Fixed by #116437
Assignees
@stevendanna
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-0 Issues/test failures with a fix SLA of 2 weeks T-disaster-recovery
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 14, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.backup/KMS/AWS/n3cpu4 failed with artifacts on release-23.2 @ 05147e54828e25044b099b7afa13a4adb066abda:

test backup/KMS/AWS/n3cpu4 failed during post test assertions (see test-post-assertions.log) due to (test_runner.go:1183).func1: context canceled
test artifacts and logs in: /artifacts/backup/KMS/AWS/n3cpu4/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=aws
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=true
  • ROACHTEST_fs=ext4
  • ROACHTEST_localSSD=true
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

Grafana is not yet available for aws clusters

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-34617
@cockroach-teamcity cockroach-teamcity added branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Dec 14, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Dec 14, 2023
@stevendanna
Copy link
Collaborator

Looks possibly related to 0dac540 or 2c685f0.

@stevendanna stevendanna self-assigned this Dec 14, 2023
@stevendanna stevendanna mentioned this issue Dec 14, 2023
Merged
@stevendanna stevendanna added P-0 Issues/test failures with a fix SLA of 2 weeks and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 14, 2023
@stevendanna
Copy link
Collaborator

Marked as high only because this could cause many roachtests to erroneously error.

craig bot pushed a commit that referenced this issue Dec 14, 2023
@stevendanna
Merge #116437
da553e3 
116437: roachtestutil: don't reference context after cancellation r=renatolabs a=stevendanna

Previously, CheckInvalidDescriptors accessed `rows` after RunWithTimeout already returned. This is a problem because the context passed to db.QueryContext is retained by the returned rows object. That context is in turn cancelled when RunWithTimeout returns.

As a result, it is possible to see a context cancelled error when accessing rows if it observes the context cancellation quickly enough.

Fixes #116426

Release note: None

Co-authored-by: Steven Danna <[email protected]>
@craig craig bot closed this as completed in ab0983d Dec 14, 2023
blathers-crl bot pushed a commit that referenced this issue Dec 14, 2023
@stevendanna
roachtestutil: don't reference context after cancellation
dbd76c3 
Previously, CheckInvalidDescriptors accessed `rows` after
RunWithTimeout already returned. This is a problem because the context
passed to db.QueryContext is retained by the returned rows object.
That context is in turn cancelled when RunWithTimeout returns.

As a result, it is possible to see a context cancelled error when
accessing rows if it observes the context cancellation quickly enough.

Fixes #116426

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevendanna stevendanna

Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-0 Issues/test failures with a fix SLA of 2 weeks T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

roachtestutil: don't reference context after cancellation stevendanna/cockroach
2 participants
@stevendanna @cockroach-teamcity