Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver/batcheval: TestEvalAddSSTable failed #115917

Closed
cockroach-teamcity opened this issue Dec 9, 2023 · 3 comments
Closed

kv/kvserver/batcheval: TestEvalAddSSTable failed #115917

cockroach-teamcity opened this issue Dec 9, 2023 · 3 comments
Assignees
@arulajmani
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-kv KV Team X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 9, 2023 •
edited by cockroach-jira-scripts
Loading

kv/kvserver/batcheval.TestEvalAddSSTable failed on master @ 22d9482e646ae127981386d77b7ebf729346fc3b:

=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_allows_sst_range_keys_contained_within_engine_range_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowShadowingBelow_is_not_generally_idempotent
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowShadowingBelow_above_limit_errors_below_existing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/SSTTimestampToRequestTimestamp_errors_with_DisallowShadowing_below_existing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/SSTTimestampToRequestTimestamp_succeeds_with_DisallowShadowing_and_idempotent_writes
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowConflicts_disallows_sst_point_keys_below_engine_range_key
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowingBelow_collision_SST_start,_existing_start,_above
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowingBelow_tombstone_above_tombstone
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/SSTTimestampToRequestTimestamp_with_DisallowConflicts_causes_estimated_stats_with_range_key_masking
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowConflict_does_not_miss_deleted_ext_keys_2
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowConflicts_allows_sst_range_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowingBelow_above_limit_errors_below_existing_with_same_value
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowConflicts_allows_sst_range_keys_2
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowConflicts_returns_engine_intents_below_sst_range_keys_as_lock_conflict_errors
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowConflicts_calculates_stats_correctly_for_merged_range_keys_2
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowShadowingBelow_can_be_used_with_DisallowShadowing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_correctly_accounts_for_complex_fragment_cases_4
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowingBelow_disallows_sst_range_keys_shadowing_live_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowing_returns_LockConflictError_in_span
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowConflict_does_not_double_count_deleted_ext_key
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowingBelow_allows_SST_range_tombstones
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowShadowing_rejects_SST_tombstones_when_shadowing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_allows_SST_tombstones_when_shadowing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_correctly_accounts_for_complex_fragment_cases
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowShadowingBelow_above_limit_errors_on_replacing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_allows_fragmented_straddling_sst_range_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=8
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=8/ApproximateDiskBytes=0/blind_writes_below_existing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/blind_errors_on_AddSSTableRequireAtRequestTimestamp
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowConflicts_returns_LockConflictError_in_span
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/blind_rejects_local_timestamp_under_race_only
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_does_not_skip_sst_range_keys_ahead_of_first_one
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowShadowing_returns_WriteTooOldError_at_existing_tombstone
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowShadowingBelow_errors_above_existing
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowConflict_does_not_repeatedly_count_ext_value_deleted_by_ext_range
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowConflict_handles_complex_range_key_cases
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowConflicts_allows_sst_and_engine_range_keys_with_no_points
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowShadowingBelow_errors_above_existing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowConflicts_allows_SST_tombstones_when_shadowing
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowConflicts_correctly_accounts_for_complex_fragment_cases_3
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowConflicts_does_not_skip_sst_range_keys_ahead_of_first_one
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflicts_MVCC_stats_with_point_tombstone_below_range_tombstone
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowConflicts_calculates_stats_correctly_for_merged_range_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=true/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowConflict_handles_complex_range_key_cases_2
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=0/DisallowConflict_does_not_miss_deleted_ext_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=0/ApproximateDiskBytes=1000000/DisallowShadowing_allows_new_SST_inline_values
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=0/DisallowConflicts_WriteTooOldError_straddling_multiple_existing_range_tombstones
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowConflict_does_not_miss_deleted_ext_keys
=== RUN   TestEvalAddSSTable/IngestAsWrites=false/RewriteConcurrency=8/ApproximateDiskBytes=1000000/DisallowShadowingBelow_is_not_generally_idempotent_with_tombstones

Parameters:

  • attempt=1
  • deadlock=true
  • run=1
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/kv

This test on roachdash | Improve this report!

Jira issue: CRDB-34293
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Dec 9, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 9, 2023
@arulajmani arulajmani added A-testing Testing tools and infrastructure X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 11, 2023
@arulajmani
Copy link
Collaborator

Looks like an infra flake. There's nothing meaningful in the logs, and the test output is littered with:

No pass/skip/fail event found for test

@arulajmani arulajmani self-assigned this Dec 11, 2023
@rickystewart
Copy link
Collaborator

rickystewart commented Dec 11, 2023 •
edited
Loading

@arulajmani Those symptoms are consistent with an OOM. If the problem recurs then a skip under deadlock might be in order (or, if there is some memory leak, then fixing that could be good).

@rickystewart
Copy link
Collaborator

The problem has recurred under deadlock in this run. I'm going to get a PR in to skip.

rickystewart added a commit to rickystewart/cockroach that referenced this issue Dec 15, 2023
@rickystewart
batcheval: skip TestEvalAddSSTable under deadlock
99f9760 
Informs cockroachdb#115917

Epic: CRDB-8308
Release note: None
@rickystewart rickystewart mentioned this issue Dec 15, 2023
Merged
craig bot pushed a commit that referenced this issue Dec 15, 2023
@rickystewart
Merge #116545
512fc0e 
116545: batcheval: skip `TestEvalAddSSTable` under `deadlock` r=rail,arulajmani a=rickystewart

Informs #115917

Epic: CRDB-8308
Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
@github-project-automation github-project-automation bot moved this to Closed in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-kv KV Team X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue
Projects
No open projects
KV
Archived in project
Milestone
24.1
Development

No branches or pull requests
3 participants
@rickystewart @arulajmani @cockroach-teamcity