backupccl: disabling S3DisableContentMD5Validation causes uploads to object locked buckets to fail #115602
Assignees
Labels
A-disaster-recovery
branch-release-23.1
Used to mark GA and release blockers, technical advisories, and bugs for 23.1
branch-release-23.2
Used to mark GA and release blockers, technical advisories, and bugs for 23.2
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-support
Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs
P-0
Issues/test failures with a fix SLA of 2 weeks
T-disaster-recovery
Comments
adityamaru
added
C-bug
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
cc @cockroachdb/disaster-recovery |
This was referenced Dec 5, 2023
adityamaru
removed
the
release-blocker
craig bot
pushed a commit
that referenced
this issue
Dec 6, 2023
115671: storage: populate OmitInRangefeeds in MVCC code r=RaduBerinde a=RaduBerinde This change populates the `MVCCValueHEader.OmitInRangeFeeds` flag based on the corresponding flag in the transaction. Fixes: #113634 Release note: None 115707: sql: prevent creating indexes on arrays of non-indexable types r=DrewKimball,fqazi,rafiss a=chrisseto #### ae7fbfb sql: prevent creating indexes on arrays of non-indexable types Previously, it was possible to circumvent the check performed by `ColumnTypeIsIndexable` and `ColumnTypeIsInvertedIndexable` by wrapping a type in an array. Doing so would violate some invariants across the system and lead to undefined behavior. This commit updates both `ColumnTypeIsIndexable` and `ColumnTypeIsInvertedIndexable` to unwrap array types, as necessary, to prevent invalid indexes from being created. Fixes: #115701 Epic: none Release note (bug fix): Standard and inverted indexes may no longer be created on REFCURSOR[]s columns. REFCURSOR columns themselves are not indexable. 115713: Revert "s3: disable content pre-upload checksums" r=stevendanna a=adityamaru This reverts commit 50c453a. Release note (bug fix): fixes a regression that causes uploads to object locked buckets to fail because of the absence of an MD5 hash Informs: #115602 Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Chris Seto <[email protected]> Co-authored-by: adityamaru <[email protected]>
|
This has been reverted on all branches and a regression test has been added. |
shralex
added
the
O-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #115197 we introduced a regression where uploads to object locked buckets will fail as they require
S3DisableContentMD5Validationto be set to false. The error is of the formclosing object: upload failed: InvalidRequest: Content-MD5 OR x-amz-checksum- HTTP header is required for Put Object requests with Object Lock parameters. This issue tracks the revert and follow up fixes to this regression. The regression is in unreleased code and so there is no customer impact.As part of resolving this release blocker we should write a regression test that runs a backup to an object lock bucket to ensure that something fails were this change to be made in the future.
Jira issue: CRDB-34120
The text was updated successfully, but these errors were encountered: