Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamingccl: ALTER TENANT ... COMPLETE REPLICATION ... should set the cutoverTS to startTime if initial scan has not complete #114734

Closed
msbutler opened this issue Nov 20, 2023 · 2 comments · Fixed by #114876
Closed

streamingccl: ALTER TENANT ... COMPLETE REPLICATION ... should set the cutoverTS to startTime if initial scan has not complete #114734

msbutler opened this issue Nov 20, 2023 · 2 comments · Fixed by #114876
Assignees
@msbutler
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Nov 20, 2023 •
edited by cockroach-jira-scripts
Loading

Currently if the user runs ALTER TENANT ... COMPLETE REPLICATION ... before the initial scan has complete, the statement fails. Instead, the cmd should the cutover time to the job start time.

Jira issue: CRDB-33657
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels Nov 20, 2023
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 20, 2023

cc @cockroachdb/disaster-recovery

@msbutler msbutler mentioned this issue Nov 20, 2023
Merged
craig bot pushed a commit that referenced this issue Nov 20, 2023
@msbutler
streamingccl: deflake TestStreamingMismatchedMRDatabase
57d260f 
Previously, this test would flake because it would attempt set a cutover
timestamp before the initial scan completed, causing an error due to #114734.
To prevent this flake, the test now waits for the initial scan to complete
before cutover.

Informs #114669

Epic: none
craig bot pushed a commit that referenced this issue Nov 20, 2023
@msbutler
Merge #114736
5150c91 
114736: streamingccl: deflake TestStreamingMismatchedMRDatabase r=adityamaru a=msbutler

Previously, this test would flake because it would attempt set a cutover timestamp before the initial scan completed, causing an error due to #114734. To prevent this flake, the test now waits for the initial scan to complete before cutover.

Informs #114669

Epic: none

Co-authored-by: Michael Butler <[email protected]>
@blathers-crl blathers-crl bot mentioned this issue Nov 20, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Nov 20, 2023
@msbutler
streamingccl: deflake TestStreamingMismatchedMRDatabase
5d57297 
Previously, this test would flake because it would attempt set a cutover
timestamp before the initial scan completed, causing an error due to #114734.
To prevent this flake, the test now waits for the initial scan to complete
before cutover.

Informs #114669

Epic: none
@msbutler msbutler mentioned this issue Nov 22, 2023
Merged
@msbutler msbutler self-assigned this Nov 22, 2023
craig bot pushed a commit that referenced this issue Nov 27, 2023
@stevendanna @msbutler
Merge #113851 #114876
078c69a 
113851: backupccl: add tenant operations to backup nemesis r=dt a=stevendanna

This adds:

  - CREATE TENANT
  - DROP TENANT
  - ALTER TENANT .. RENAME
  - CREATE TENANT FROM REPLICATION

To our tenant backup nemesis tests. Additionally, it modifies the test to occasionally use cluster backups over tenant-level backups.

Fixes #108745

Release note: None

114876: streamingccl: allow CUTOVER TO LATEST before initial scan finishes r=stevendanna a=msbutler

This patch allows the user to execute ALTER TENANT x COMPLETE REPLICATION TO LATEST before the initial scan completes. After this cmd, the cutover time is set to the replicated start time.

Fixes: #114734

Epic: none

Co-authored-by: Steven Danna <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in d457b0c Nov 27, 2023
@blathers-crl blathers-crl bot mentioned this issue Nov 27, 2023
Merged
msbutler added a commit to msbutler/cockroach that referenced this issue Nov 28, 2023
@msbutler
streamingccl: allow CUTOVER TO LATEST before initial scan finishes
bcdc589 
This patch allows the user to execute ALTER TENANT x COMPLETE REPLICATION TO
LATEST before the initial scan completes. After this cmd, the cutover time is
set to the replicated start time.

Fixes: cockroachdb#114734

Epic: none
@exalate-issue-sync exalate-issue-sync bot reopened this Mar 15, 2024
@msbutler
Copy link
Collaborator Author

exalate weirdness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbutler msbutler

Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

streamingccl: allow CUTOVER TO LATEST before initial scan finishes msbutler/cockroach
1 participant
@msbutler