Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: prefix all logs with worker tags #114045

Closed
RaduBerinde opened this issue Nov 8, 2023 · 1 comment · Fixed by #124027
Closed

roachtest: prefix all logs with worker tags #114045

RaduBerinde opened this issue Nov 8, 2023 · 1 comment · Fixed by #124027
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-testeng TestEng Team

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Nov 8, 2023 •
edited by cockroach-jira-scripts
Loading

Many of the runner logs don't have the worker tag (see below). It would be ideal if all messages had it and you could in principle break up the logs by wX tags to see what each worker is doing.

19:56:24 test_runner.go:743: [w1] Starting test: gopg:1 on cluster=teamcity-12554668-1699382900-25-n1cpu4 (arch="amd64")
19:56:24 cluster_synced.go:1984: teamcity-12554668-1699382900-25-n1cpu4: putting (scp) /go/src/github.com/cockroachdb/cockroach/bin/cockroach.linux-amd64 ./cockroach-default on nodes [1]
19:56:36 cluster_synced.go:2186: 
19:56:36 cluster_synced.go:2191:    1: done
19:56:36 cluster_synced.go:2191:    2: done
19:56:36 cluster_synced.go:2191:    3: done
19:56:36 cluster_synced.go:2191:    4: done
19:56:36 cluster_synced.go:2191:    5: done
19:56:36 cluster_synced.go:2191:    6: done
19:56:36 cluster_synced.go:2191:    7: done
19:56:36 cluster_synced.go:2191:    8: done
19:56:36 cluster_synced.go:2191:    9: done
19:56:41 cluster_synced.go:2186: 
19:56:41 cluster_synced.go:2191:    1: done
19:57:23 roachprod.go:1271: OK
19:57:23 cluster.go:1668: destroying cluster teamcity-12554668-1699382900-08-n3cpu4 [tag:] (3 nodes)... done
19:57:26 test_runner.go:613: [w4] Releasing quota for 12 CPUs

Jira issue: CRDB-33316
@RaduBerinde RaduBerinde added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Nov 8, 2023
@blathers-crl blathers-crl bot added the T-testeng TestEng Team label Nov 8, 2023
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 8, 2023

cc @cockroachdb/test-eng

@srosenberg srosenberg added the E-quick-win Likely to be a quick win for someone experienced. label Nov 16, 2023
@exalate-issue-sync exalate-issue-sync bot removed the E-quick-win Likely to be a quick win for someone experienced. label Nov 16, 2023
@srosenberg srosenberg added the E-quick-win Likely to be a quick win for someone experienced. label Nov 20, 2023
@vidit-bhat vidit-bhat mentioned this issue May 13, 2024
Merged
vidit-bhat added a commit to vidit-bhat/cockroach that referenced this issue May 13, 2024
@vidit-bhat
roachtest: prefix all logs with worker tags
336d8c3 
Previously, many of the runner logs didn't have the worker tags.
This was inadequate because we couldn't break up the logs by wX
tags to see what each worker is doing.
This PR prefixes the worker tags to logs that were missing them.

Epic: none
Fixes: cockroachdb#114045
Release note: None
craig bot pushed a commit that referenced this issue May 14, 2024
@vidit-bhat
Merge #124027
1e9eabb 
124027: roachtest: prefix all logs with worker tags r=vidit-bhat a=vidit-bhat

Previously, many of the runner logs didn't have the worker tags. This was inadequate because we couldn't break up the logs by `wX` tags to see what each worker was doing.
This PR prefixes worker tags to the logs that were missing them.

Epic: none
Fixes: #114045
Release note: None

Co-authored-by: Vidit Bhat <[email protected]>
@craig craig bot closed this as completed in 0a2f34e May 14, 2024
vidit-bhat added a commit to vidit-bhat/cockroach that referenced this issue May 14, 2024
@vidit-bhat
roachtest: prefix all logs with worker tags
7733e3a 
Previously, many of the runner logs didn't have the worker tags.
This was inadequate because we couldn't break up the logs by wX
tags to see what each worker is doing.
This PR prefixes the worker tags to logs that were missing them.

Epic: none
Fixes: cockroachdb#114045
Release note: None
@vidit-bhat vidit-bhat mentioned this issue May 14, 2024
Merged
vidit-bhat added a commit to vidit-bhat/cockroach that referenced this issue May 14, 2024
@vidit-bhat
roachtest: prefix all logs with worker tags
24798d4 
Previously, many of the runner logs didn't have the worker tags.
This was inadequate because we couldn't break up the logs by wX
tags to see what each worker is doing.
This PR prefixes the worker tags to logs that were missing them.

Epic: none
Fixes: cockroachdb#114045
Release note: None
@vidit-bhat vidit-bhat mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-testeng TestEng Team
Projects
No open projects
Test Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: prefix all logs with worker tags vidit-bhat/cockroach
2 participants
@srosenberg @RaduBerinde