Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: surface cloud cluster spec info in artifacts #112707

Closed
jbowens opened this issue Oct 19, 2023 · 1 comment · Fixed by #124243
Closed

roachtest: surface cloud cluster spec info in artifacts #112707

jbowens opened this issue Oct 19, 2023 · 1 comment · Fixed by #124243
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@jbowens
Copy link
Collaborator

jbowens commented Oct 19, 2023

It's often necessary to understand the particulars of a roachtest run's environment. In particular, on the storage team we often need to know the bandwidth and IOPS limits of disks, and whether they're persistent disk or local SSDs. Today, this data is tricky to derive involving reading source code, mapping instance types per-Cloud provider and looking up Cloud-provider docs to establish bandwidth/IOPS limits. Surfacing information about the cloud provider cluster specification within the artifacts would ease this process.

Internal slack link: https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1697737111168569

Jira issue: CRDB-32561

@jbowens jbowens added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-testeng TestEng Team labels Oct 19, 2023
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2023

cc @cockroachdb/test-eng

vidit-bhat added a commit to vidit-bhat/cockroach that referenced this issue May 16, 2024
Previously, getting the spec of the VMs on which a roachtest
ran was tricky to derive.
This was inadequate because it's often necessary to understand
the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing
its spec in. These files are stored in the Artifacts directory.

Epic: none
Fixes: cockroachdb#112707
Release note: None
vidit-bhat added a commit to vidit-bhat/cockroach that referenced this issue May 17, 2024
Previously, getting the spec of the VMs on which a roachtest
ran was tricky to derive.
This was inadequate because it's often necessary to understand
the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing
its spec in. These files are stored in the Artifacts directory.

Epic: none
Fixes: cockroachdb#112707
Release note: None
craig bot pushed a commit that referenced this issue May 20, 2024
124243: roachtest: surface cloud cluster spec info in artifacts r=vidit-bhat a=vidit-bhat

Previously, getting the spec of the VMs on which a roachtest ran was tricky to derive.
This was inadequate because it's often necessary to understand the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing its spec. These files are stored under `artifacts/vm_spec`.

Epic: none
Fixes: #112707
Release note: None

Co-authored-by: Vidit Bhat <[email protected]>
@craig craig bot closed this as completed in 0e3ae2c May 20, 2024
blathers-crl bot pushed a commit that referenced this issue May 24, 2024
Previously, getting the spec of the VMs on which a roachtest
ran was tricky to derive.
This was inadequate because it's often necessary to understand
the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing
its spec in. These files are stored in the Artifacts directory.

Epic: none
Fixes: #112707
Release note: None
vidit-bhat added a commit to vidit-bhat/cockroach that referenced this issue May 24, 2024
Previously, getting the spec of the VMs on which a roachtest
ran was tricky to derive.
This was inadequate because it's often necessary to understand
the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing
its spec in. These files are stored in the Artifacts directory.

Epic: none
Fixes: cockroachdb#112707
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants