if with identical then and else blocks in sql/sem/tree/backup.go

[chavacava]

cockroach/pkg/sql/sem/tree/backup.go

Lines 204 to 211 in 2da2993

	if ctx.HasFlags(FmtHideConstants) {
	ctx.WriteString(" WITH OPTIONS (")
	ctx.FormatNode(&node.Options)
	ctx.WriteString(")")
	} else {
	ctx.WriteString(" WITH OPTIONS (")
	ctx.FormatNode(&node.Options)
	ctx.WriteString(")")

cockroach/pkg/sql/sem/tree/backup.go

Lines 523 to 531 in 2da2993

	if ctx.HasFlags(FmtHideConstants) {
	maybeAddSep()
	ctx.WriteString("execution locality = ")
	ctx.FormatNode(o.ExecutionLocality)
	} else {
	maybeAddSep()
	ctx.WriteString("execution locality = ")
	ctx.FormatNode(o.ExecutionLocality)
	}

In both conditionals, then and else blocks are identical.

(found by revive while testing it on cockroach code base)

Jira issue: CRDB-32067

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I have CC'd a few people who may be able to assist you:

• @cockroachdb/disaster-recovery (found keywords: backup)

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[blathers-crl]

cc @cockroachdb/disaster-recovery