Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/catalog/lease: TestLeaseManagerReacquire failed #110642

Closed
cockroach-teamcity opened this issue Sep 14, 2023 · 2 comments · Fixed by #112613
Closed

sql/catalog/lease: TestLeaseManagerReacquire failed #110642

cockroach-teamcity opened this issue Sep 14, 2023 · 2 comments · Fixed by #112613
Assignees
@fqazi
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 14, 2023 •
edited by cockroach-jira-scripts
Loading

sql/catalog/lease.TestLeaseManagerReacquire failed with artifacts on master @ 0cde11b885a5e156b970c003505acd081fb4f326:

=== RUN   TestLeaseManagerReacquire
    test_log_scope.go:167: test logs captured to: /artifacts/tmp/_tmp/ce8d73b4a4081f39d36a7fa2c2508fcc/logTestLeaseManagerReacquire73285229
    test_log_scope.go:81: use -show-logs to present logs inline
    test_server_shim.go:124: automatically injected virtual cluster under test; see comment at top of test_server_shim.go for details.
    testcluster.go:495: polling for queued jobs to complete: liveness session expired 11.248409ms before transaction
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/ce8d73b4a4081f39d36a7fa2c2508fcc/logTestLeaseManagerReacquire73285229
--- FAIL: TestLeaseManagerReacquire (37.55s)

Parameters: TAGS=bazel,gss,deadlock , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-31540
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Sep 14, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Sep 14, 2023
@rafiss
Copy link
Collaborator

rafiss commented Sep 14, 2023

@fqazi since you are working close to leasing right now, can you check if this test needs to be adjusted?

@fqazi
Copy link
Collaborator

fqazi commented Sep 14, 2023

Yeah, let me look into it

@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 20, 2023
@cockroach-teamcity cockroach-teamcity mentioned this issue Oct 11, 2023
Closed
@fqazi fqazi mentioned this issue Oct 18, 2023
Merged
fqazi added a commit to fqazi/cockroach that referenced this issue Oct 18, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
21cdfef 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: cockroachdb#112392,cockroachdb#110642

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Oct 23, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
395592f 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: cockroachdb#112392,cockroachdb#110642

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Oct 31, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
762874c 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: cockroachdb#112392,cockroachdb#110642

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Oct 31, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
843ac13 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: cockroachdb#112392,cockroachdb#110642

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Nov 1, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
f620651 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: cockroachdb#112392,cockroachdb#110642

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Nov 1, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
3b46520 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: cockroachdb#112392,cockroachdb#110642

Release note: None
@craig craig bot closed this as completed in bfc5c35 Nov 1, 2023
blathers-crl bot pushed a commit that referenced this issue Nov 1, 2023
@fqazi
jobs: handle retryable errors waiting for jobs
605872b 
Previously, when waiting for jobs if the internal executor hit any
retryable errors, we would incorrectly bubble these errors up. This
would intermittently be seen in leasing tests, which intentionally
disable renewals, increasing the likelihood of transaction retry errors.
To address this, this patch will modify waitForJobs to handle retryable
errors gracefully.

Fixes: #112392,#110642

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

jobs: handle retryable errors waiting for jobs fqazi/cockroach
3 participants
@rafiss @fqazi @cockroach-teamcity