Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverutils: flake in tests that use ALTER TENANT SET CLUSTER SETTING #110560

Closed
knz opened this issue Sep 13, 2023 · 2 comments · Fixed by #110789 or #110947
Closed

serverutils: flake in tests that use ALTER TENANT SET CLUSTER SETTING #110560

knz opened this issue Sep 13, 2023 · 2 comments · Fixed by #110789 or #110947
Assignees
Labels
A-multitenancy Related to multi-tenancy C-test-failure Broken test (automatically or manually discovered). db-cy-23 T-multitenant Issues owned by the multi-tenant virtual team

Comments

@knz
Copy link
Contributor

knz commented Sep 13, 2023

Describe the problem

Found by @miretskiy in #110516:

=== RUN   TestAlterChangefeedSwitchFamily/kafka
    alter_changefeed_test.go:282: failed to start feed for job 0: pq: rangefeeds require the kv.rangefeed.enabled setting. See https://www.cockroachlabs.com/docs/v23.2/change-data-capture.html#enable-rangefeeds-to-reduce-latency

In a nutshell the test does this:

  1. StartServer()
  2. ALTER TENANT ALL SET CLUSTER SETTING kv.rangefeed.enabled = true via SQL
  3. StartTenant()

then the error happens when the test uses the tenant service.

The problem is that the setting override at step (2) has not yet propagated through the rangefeed when StartTenant is invoked.

Expected behavior

StartTenant should also restart the rangefeed on the setting overrides (currnetly it only restarts the rangefeed on the tenant metadata and capabilities).

Jira issue: CRDB-31506
Epic: CRDB-18499

@knz knz added C-test-failure Broken test (automatically or manually discovered). release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 13, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 13, 2023

Hi @knz, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@knz knz added A-multitenancy Related to multi-tenancy T-multitenant Issues owned by the multi-tenant virtual team labels Sep 13, 2023
@stevendanna stevendanna self-assigned this Sep 13, 2023
@knz knz added branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 and removed branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Sep 13, 2023
@exalate-issue-sync exalate-issue-sync bot removed the branch-master Failures and bugs on the master branch. label Sep 13, 2023
@knz knz removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 13, 2023
@knz knz self-assigned this Sep 17, 2023
@craig craig bot closed this as completed in 19d0030 Sep 19, 2023
@knz
Copy link
Contributor Author

knz commented Sep 19, 2023

sadly my patch didn't fully fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy C-test-failure Broken test (automatically or manually discovered). db-cy-23 T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
2 participants