Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: port version/mixed/nodes=%d to new mixed-version framework #110538

Closed
srosenberg opened this issue Sep 13, 2023 · 2 comments · Fixed by #113323
Closed

roachtest: port version/mixed/nodes=%d to new mixed-version framework #110538

srosenberg opened this issue Sep 13, 2023 · 2 comments · Fixed by #113323
Assignees
@DarrylWong
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-testeng TestEng Team

Comments

@srosenberg
Copy link
Member

srosenberg commented Sep 13, 2023 •
edited by cockroach-jira-scripts
Loading

See the parent issue [1] for details. Note that this test appears to be a good candidate for removal since it's redundant with other existing tests. Renato's comment,

One thing that it does have is variance on the number of nodes in the cluster (most other tests just do a basic 3-node cluster). This could be incorporated into the framework at some point as well.

[1] #110528

Jira issue: CRDB-31488
@srosenberg srosenberg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Sep 13, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 13, 2023

cc @cockroachdb/test-eng

@blathers-crl
Copy link

blathers-crl bot commented Oct 1, 2023

Hi @lunevalex, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@DarrylWong DarrylWong self-assigned this Oct 30, 2023
@DarrylWong DarrylWong mentioned this issue Oct 30, 2023
Merged
craig bot pushed a commit that referenced this issue Oct 31, 2023
@stevendanna @DarrylWong
Merge #113280 #113323
41c9a0f 
113280: streamingccl: add setting to disable mux rangefeeds r=msbutler a=stevendanna

Since mux rangefeeds are still default off, we want the ability to opt out of them if we find an issue with them.

Epic: none

Release note: None

113323: roachtest: delete version/mixed tests r=renatolabs a=DarrylWong

This commit deletes the version/mixed roachtests. These tests do very little, only testing that upgrades finish. This is tested by other mixed-version tests, rendering these tests redundant.

Note that these tests did test upgrades for clusters of size 5, something we don't do elsewhere. However it isn't worth it to have a separate test for this.

Release note: None

Epic: CRDB-19321
Fixes: #110538
Informs: #110528

Co-authored-by: Steven Danna <[email protected]>
Co-authored-by: DarrylWong <[email protected]>
@craig craig bot closed this as completed in 832bbc5 Oct 31, 2023
blathers-crl bot pushed a commit that referenced this issue Oct 31, 2023
@DarrylWong
roachtest: delete version/mixed tests
c2f84b8 
This commit deletes the version/mixed roachtests. These tests
do very little, only testing that upgrades finish. This
is tested by other mixed-version tests, rendering these tests
redundant.

Note that these tests did test upgrades for clusters of size 5,
something we don't do elsewhere. However it isn't worth it to
have a seperate test for this.

Release note: None

Epic: CRDB-19321
Fixes: #110538
Informs: #110528
@blathers-crl blathers-crl bot mentioned this issue Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarrylWong DarrylWong

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-testeng TestEng Team
Projects
No open projects
Test Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: delete version/mixed tests DarrylWong/fork
3 participants
@srosenberg @DarrylWong @lunevalex