storage: add replicated locks to storage metamorphic testing #109650
Assignees
Labels
A-read-committed
Related to the introduction of Read Committed
A-storage
Relating to our storage engine (Pebble) on-disk storage.
A-testing
Testing tools and infrastructure
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-storage
Storage Team
Comments
nvanbenschoten
added
A-storage
nvanbenschoten
added
the
C-enhancement
|
Note for @bananabrick - might also be worth taking a look at #96290, and address while we're in here. |
itsbilal
added a commit
to itsbilal/cockroach
that referenced
this issue
Nov 2, 2023
This change adds two new operations to the MVCC metamorphic testing package that were added in cockroachdb#110323. We check for determinism in the storage package by adding these operations to the metamorphic tests as well. Fixes cockroachdb#109650. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this issue
Nov 3, 2023
113643: roachtest: move validate-after-version-upgrade to new framework r=rafiss a=rafiss The new framework provides a few more testing enhancements and is the only one that will be maintained. fixes #110535 Release note: None 113676: roachtest: fix js install command (gpg) r=rafiss a=annrpom We are seeing a `gpg: cannot open '/dev/tty': No such device or address` error from the new installation method we followed. Resolution seems to be nodejs/docker-node#922. In case we are running into an issue with machines being reused, we first check to see if we can install nodejs and npm before we add a nodesource key and deb repository (to prevent gpg: dearmoring failed: File exists) issues. (Copied from a reply to the bug report in the issue linked above) > For any script use you should anyway use --batch which disables the use of the tty as a side-effect. Fixes: #113673 Fixes: #113662 Fixes: #113659 Fixes: #113675 Fixes: #113677 Fixes: #113762 Release note: None 113698: metamorphic: add MVCC{CheckFor,}AcquireLock operations r=nvanbenschoten a=itsbilal This change adds two new operations to the MVCC metamorphic testing package that were added in #110323. We check for determinism in the storage package by adding these operations to the metamorphic tests as well. Fixes #109650. Epic: none Release note: None Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Annie Pompa <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #100193, we should add replicated locks to the metamorphic testing in
pkg/storage/metamorphic. In practice, this would mean exercising the two new functions added in #110323.Jira issue: CRDB-31034
The text was updated successfully, but these errors were encountered: