concurrency: integrate lock modes with SKIP LOCKED #108715
Labels
A-kv-transactions
Relating to MVCC and the transactional model.
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-kv
KV Team
Describe the problem
Currently, SKIP LOCKED (via
IsKeyLockedByConflictingTxn
) performs bespoke conflict resolution, around:cockroach/pkg/kv/kvserver/concurrency/lock_table.go
Lines 708 to 720 in ea59ee1
This bakes in the assumption that the lock is of strength Exclusive/Intent. As such, SKIP LOCKED doesn't account for other lock strengths (notably Shared) correctly. We should switch out this function to make use of lock modes instead.
Jira issue: CRDB-30609
The text was updated successfully, but these errors were encountered: