Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestBackupSuccess_base_alter_table_multiple_commands is flaky #108221

Closed
mgartner opened this issue Aug 4, 2023 · 7 comments
Closed

sql: TestBackupSuccess_base_alter_table_multiple_commands is flaky #108221

mgartner opened this issue Aug 4, 2023 · 7 comments
Assignees
@Xiang-Gu
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@mgartner
Copy link
Collaborator

mgartner commented Aug 4, 2023 •
edited by cockroach-jira-scripts
Loading

Seen here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/11197865?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildProblemsSection=true&expandBuildTestsSection=true

Jira issue: CRDB-30366
@mgartner mgartner added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 4, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Aug 4, 2023
@jbowens
Copy link
Collaborator

jbowens commented Aug 4, 2023

And here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/11198814?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true&expandBuildProblemsSection=true

@jbowens jbowens added the C-test-failure Broken test (automatically or manually discovered). label Aug 4, 2023
@mgartner
Copy link
Collaborator Author

mgartner commented Aug 4, 2023

I don't think this is flaky, just broken. I can't get it to pass in CI after 10+ re-runs.

@adityamaru adityamaru mentioned this issue Aug 4, 2023
Merged
@rharding6373
Copy link
Collaborator

Another failure: https://teamcity.cockroachdb.com/viewLog.html?buildId=11199019&buildTypeId=Cockroach_Ci_TestsGcpLinuxX8664BigVm_CclUnitTests&tab=buildResultsDiv

The test is timing out:
shard 7:

=== RUN   TestBackupSuccessMixedVersion_base_alter_table_alter_primary_key_drop_rowid/post_commit_stage_10_of_15
panic: test timed out after 14m55s

shard 16:

=== RUN   TestBackupSuccess_base_alter_table_multiple_commands/post_commit_stage_18_of_31
panic: test timed out after 14m55s

There don't appear to be any changes to the testdata directory in 2 weeks, so something else caused the test time to go over the test timeout, maybe.

This was referenced Aug 5, 2023
Merged
Merged
@otan
Copy link
Contributor

otan commented Aug 7, 2023

maybe #108238 is the CI issue

@Xiang-Gu Xiang-Gu mentioned this issue Aug 7, 2023
Merged
@rafiss rafiss mentioned this issue Aug 7, 2023
Closed
craig bot pushed a commit that referenced this issue Aug 7, 2023
@Xiang-Gu
Merge #108289
898c592 
108289: schemachanger: Skip some reported timeout backup tests r=rafiss a=Xiang-Gu

There has been a few timeout failures from the BACKUP/RESTORE testing suites so let's skip
them for now until we know more of the issue.

Informs ##108238
Informs #108221
Epic: None
Release note: None

Co-authored-by: Xiang Gu <[email protected]>
@pav-kv
Copy link
Collaborator

pav-kv commented Aug 8, 2023

Multiple tests under TestBackupSuccessMixedVersion_base_alter_table_alter_primary_key_drop_rowid failed here.

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Aug 9, 2023 •
edited
Loading

My recent effort to deflake those tests was merged. It also unskip those flaky tests. Let's see if it made it better.

@rafiss
Copy link
Collaborator

rafiss commented Aug 11, 2023

Thank you! It has not flaked in the 3 days since that was merged

@rafiss rafiss closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jbowens @mgartner @rafiss @otan @pav-kv @rharding6373 @Xiang-Gu