Schema: Add comparator testing in logic tests #108183
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
rimadeodhar
added
C-enhancement
|
I'm starting to look into and proto typing comparator testing in general (#108529). Assigning this to myself. |
This was referenced Sep 7, 2023
craig bot
pushed a commit
that referenced
this issue
Sep 14, 2023
110289: sctest: Introduce comparator testing framework r=Xiang-Gu a=Xiang-Gu This PR implements core framework of the comparator testing as outlined in this [doc](https://docs.google.com/document/d/1XH_4O3mbbCshjwJAPBViyDiCVtGfMdTH8IjjFajYY0c/edit#heading=h.p2uktd8oe7ei). Fixes: #110180 Informs: #108183, #108529, #108182 Epic: [CRDB-30346](https://cockroachlabs.atlassian.net/browse/CRDB-30346) Release note: None Co-authored-by: Xiang Gu <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Oct 2, 2023
111343: nightlies: Collect logictest statements and store them onto GCS r=Xiang-Gu a=Xiang-Gu This PR adds a nightly task for TC to collect all statements in logictests and store them onto GCS. Informs: #108183 Epic: [CRDB-30346](https://cockroachlabs.atlassian.net/browse/CRDB-30346) Release note: None 111537: testserver: make implicit usages of TenantController methods explicit r=yuzefovich a=yuzefovich I was annoyed by the warning in the logic test failures, so I decided to audit all usages of `TenantController` methods to make them "explicit". Epic: None Release note: None 111602: row: add missing three dots to var arg r=yuzefovich a=yuzefovich For some reason after an update GoLand stopped compiling because of this. Epic: None Release note: None 111607: changefeedccl: add logging to TestAlterChangefeedAddTargetsDuringSchemaChangeError r=jayshrivastava a=jayshrivastava This test is flaky and it does not fail within 10k runs of stressrace and 100k runs of stress. To help uncover the cause of the flake, this change adds log messages. Release note: None Informs: #111390 Epic: None Co-authored-by: Xiang Gu <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Jayant Shrivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should add comparator checks for logic tests where we run the same test with the legacy schema changer and the declarative schema changer. These tests should check that the end state of the data and descriptors after the schema changes are the same for both. This will alert us in events where there is a divergence in the logic between the two schema changers. The legacy schema changer will treated as the ground truth for such tests.
Jira issue: CRDB-30354
Epic CRDB-30346
The text was updated successfully, but these errors were encountered: