Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/schemachanger: disable CREATE SEQUENCE / CREATE SCHEMA in declarative schema changer #107734

Closed
fqazi opened this issue Jul 27, 2023 · 0 comments · Fixed by #107815
Closed

sql/schemachanger: disable CREATE SEQUENCE / CREATE SCHEMA in declarative schema changer #107734

fqazi opened this issue Jul 27, 2023 · 0 comments · Fixed by #107815
Assignees
@fqazi
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@fqazi
Copy link
Collaborator

fqazi commented Jul 27, 2023 •
edited by cockroach-jira-scripts
Loading

We should disable CREATE SEQUENCE / CREATE SCHEMA until improved test coverage is in place. Additionally, let's introduce a cluster setting for more granular disablement of features, so that if/when bugs are found, users are not forced to flip a big switch.

Jira issue: CRDB-30176
@fqazi fqazi added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 27, 2023
@fqazi fqazi self-assigned this Jul 27, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jul 27, 2023
@fqazi fqazi mentioned this issue Jul 28, 2023
Merged
fqazi added a commit to fqazi/cockroach that referenced this issue Jul 28, 2023
@fqazi
sql/schemachanger: disable declarative CREATE statements
da131e5 
Previously, the decalrative schema changer had
CREATE SEQUENCE and CREATE SCHEMA enabled by default.
There may not be sufficient testing for both, so we
are at a risk of introducing regressiosn. To dddress this,
this patch will disable both by default to mitigate risk.

Fixes: cockroachdb#107734

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Aug 8, 2023
@fqazi
sql/schemachanger: disable declarative CREATE statements
9c36a44 
Previously, the decalrative schema changer had
CREATE SEQUENCE and CREATE SCHEMA enabled by default.
There may not be sufficient testing for both, so we
are at a risk of introducing regressiosn. To dddress this,
this patch will disable both by default to mitigate risk.

Fixes: cockroachdb#107734

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Aug 9, 2023
@fqazi
sql/schemachanger: disable declarative CREATE statements
141d961 
Previously, the decalrative schema changer had
CREATE SEQUENCE and CREATE SCHEMA enabled by default.
There may not be sufficient testing for both, so we
are at a risk of introducing regressiosn. To dddress this,
this patch will disable both by default to mitigate risk.

Fixes: cockroachdb#107734

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Aug 9, 2023
@fqazi
sql/schemachanger: disable declarative CREATE statements
76c327f 
Previously, the decalrative schema changer had
CREATE SEQUENCE and CREATE SCHEMA enabled by default.
There may not be sufficient testing for both, so we
are at a risk of introducing regressiosn. To dddress this,
this patch will disable both by default to mitigate risk.

Fixes: cockroachdb#107734

Release note: None
craig bot pushed a commit that referenced this issue Aug 10, 2023
@fqazi
Merge #107815
67e16cb 
107815: sql/schemachanger: disable CREATE SEQUENCE / CREATE SCHEMA by default in declarative schema changer r=fqazi a=fqazi

For 23.2 and keeping things more conservative, we will keep CREATE SEQUENCE / CREATE SCHEMA running
in the older declarative schema changer. This patch will do the following:

1. CREATE SEQUENCE / CREATE SCHEMA are disabled by default
2. A new cluster setting sql.schema.force_declarative_statements can now be used to enable/disable declarative features in a more granular matter.


Fixes: #107734

Co-authored-by: Faizan Qazi <[email protected]>
@craig craig bot closed this as completed in ab1a740 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
1 participant
@fqazi