Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic flakes #107353

Closed
mgartner opened this issue Jul 21, 2023 · 1 comment · Fixed by #107468
Closed

kv: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic flakes #107353

mgartner opened this issue Jul 21, 2023 · 1 comment · Fixed by #107468
Assignees
@nvanbenschoten
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-kv KV Team

Comments

@mgartner
Copy link
Collaborator

mgartner commented Jul 21, 2023 •
edited by cockroach-jira-scripts
Loading

Seen here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/10998403?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

Failed
=== RUN   TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/after_restart
    client_raft_test.go:4934:
          Error Trace:  github.com/cockroachdb/cockroach/pkg/kv/kvserver_test/pkg/kv/kvserver/client_raft_test.go:4934
                              github.com/cockroachdb/cockroach/pkg/kv/kvserver_test/pkg/kv/kvserver/client_raft_test.go:4943
          Error:        Target error should be in err chain:
                        expected: "context deadline exceeded"
                        in chain: "failed to send RPC: sending to all replicas failed; last error: ba: Put [/Table/100/\"a\",/Min) RPC error: grpc: context deadline exceeded [code 4/DeadlineExceeded]"
          Test:         TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/after_restart
          Messages:     Expected timeout writing to key range
    --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/after_restart (1.68s)

Jira issue: CRDB-30006
@mgartner mgartner added the C-test-failure Broken test (automatically or manually discovered). label Jul 21, 2023
@blathers-crl blathers-crl bot added the T-kv KV Team label Jul 21, 2023
@nvanbenschoten nvanbenschoten self-assigned this Jul 24, 2023
@nvanbenschoten
Copy link
Member 

Target error should be in err chain:
expected: "context deadline exceeded"
in chain: "failed to send RPC: sending to all replicas failed; last error: ba: Put [/Table/100/\"a\",/Min) RPC error: grpc: context deadline exceeded [code 4/DeadlineExceeded]"

The error is in that chain. It's probably being formatted instead of being wrapped correctly.

@nvanbenschoten nvanbenschoten mentioned this issue Jul 24, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 24, 2023
@zachlite @nvanbenschoten
Merge #107457 #107468
2972f13 
107457: ui: increase hot ranges page timeout r=zachlite a=zachlite

This commit increases the hot ranges request timeout to 30 minutes for both the initial fetch and the refresh.

Informs ##104269
Epic: none
Release note (bug fix): The timeout duration when loading the
Hot Ranges page has been increased to 30 minutes.

107468: kv: implement errors.Wrapper on sendError, deflake test r=knz a=nvanbenschoten

Fixes #107353.

This commit makes `sendError` implement the `errors.Wrapper` interface. This deflakes `TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic`, which was expecting a call to `require.ErrorIs` to find a `context.DeadlineExceeded` in an error chain that included a `sendError`.

Release note: None

Co-authored-by: zachlite <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in 64cfbb2 Jul 24, 2023
@tbg tbg added A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Jul 28, 2023
blathers-crl bot pushed a commit that referenced this issue Jul 5, 2024
@nvanbenschoten
kv: implement errors.Wrapper on sendError, deflake test
e57c40e 
Fixes #107353.

This commit makes `sendError` implement the `errors.Wrapper` interface.
This deflakes `TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic`,
which was expecting a call to `require.ErrorIs` to find a
`context.DeadlineExceeded` in an error chain that included a `sendError`.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kv: implement errors.Wrapper on sendError, deflake test nvanbenschoten/cockroach
3 participants
@mgartner @tbg @nvanbenschoten