Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: tpce/c=100000/nodes=5 failed #106487

Closed
cockroach-teamcity opened this issue Jul 9, 2023 · 2 comments · Fixed by #106933
Closed

roachtest: tpce/c=100000/nodes=5 failed #106487

cockroach-teamcity opened this issue Jul 9, 2023 · 2 comments · Fixed by #106933
Assignees
@postamar
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 9, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.tpce/c=100000/nodes=5 failed with artifacts on master @ 43c26aec0072f76e02e6d5ffc1b7079026b24630:

(cluster.go:2282).Run: output in run_002507.225510129_n6_sudo-docker-run-cock: sudo docker run cockroachdb/tpc-e:latest --customers 100000 --init --racks 5 --hosts=10.128.0.9 returned: COMMAND_PROBLEM: exit status 1
(monitor.go:137).Wait: monitor failure: monitor task failed: t.Fatal() was called
test artifacts and logs in: /artifacts/tpce/c=100000/nodes=5/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=32 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=2

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/test-eng

This test on roachdash | Improve this report!

Jira issue: CRDB-29583
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-testeng TestEng Team labels Jul 9, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Jul 9, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.tpce/c=100000/nodes=5 failed with artifacts on master @ b4dfdc01809da4ac76b32ec5e2ff9a50d9adeee3:

(cluster.go:2282).Run: output in run_001315.308961061_n6_sudo-docker-run-cock: sudo docker run cockroachdb/tpc-e:latest --customers 100000 --init --racks 5 --hosts=10.128.0.13 returned: COMMAND_PROBLEM: exit status 1
(monitor.go:137).Wait: monitor failure: monitor task failed: t.Fatal() was called
test artifacts and logs in: /artifacts/tpce/c=100000/nodes=5/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=32 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=2

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@renatolabs
Copy link
Contributor

Same as #106419.

@renatolabs renatolabs added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jul 17, 2023
@renatolabs renatolabs removed the T-testeng TestEng Team label Jul 17, 2023
@postamar postamar mentioned this issue Jul 17, 2023
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Jul 17, 2023
scbuild: fix concurrent schema change verification bug.
9783626 
Previously, we didn't check for concurrent schema changes on targets set
on elements that the builder state didn't know about yet. This patch
fixes this oversight. This regression was recently introduced by cockroachdb#106175.

Fixes: cockroachdb#106487

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Jul 17, 2023
scbuild: fix concurrent schema change verification bug.
b9d73b6 
Previously, we didn't check for concurrent schema changes on targets set
on elements that the builder state didn't know about yet. This patch
fixes this oversight. This regression was recently introduced by cockroachdb#106175.

Fixes: cockroachdb#106487

Release note: None
craig bot pushed a commit that referenced this issue Jul 19, 2023
@mgartner @jayshrivastava
Merge #106869 #106933 #107184
28e02cf 
106869: sql: fix CREATE OR REPLACE VIEW cross-db type reference errors r=mgartner a=mgartner

Fixes #106602

Release note (bug fix): A bug has been fixed that allowed views created
with `CREATE OR REPLACE VIEW` to reference user-defined types in other
databases, even with `sql.cross_db_views.enabled` set to `false`. This
bug was present since user-defined types were introduced in version
20.1.


106933: scbuild: fix concurrent schema change verification bug r=postamar a=postamar

Previously, we didn't check for concurrent schema changes on targets set
on elements that the builder state didn't know about yet. This patch
fixes this oversight. This regression was recently introduced by #106175.

Fixes: #106487

Release note: None


107184: changefeedccl: remove disableDeclarativeSchemaChangesForTest from two tests r=miretskiy a=jayshrivastava

This change removes the `disableDeclarativeSchemaChangesForTest` flag from two
changefeed tests and modifies them to match the new behavior.

There are two ways in which the tests are modified:

1. The timestamp associated with the rows we expect to see during a backfill
   are different with the declarative schema changer. Ex. for ADD COLUMN,
   we expect rows with the `ModificationTime` of the descriptor at version 7
   instead of 5.

2. With the new schema changer, we expect to see backfill rows only once.

   With the old schema changer, we would see KV's be re-written
   in-place while the changefeed was running (one "backfill"). Then, when
   schema change becomes "visible", we would stop the changefeed to
   perform another backfill at the schema change timestamp before moving on.

   With the new schema changer, the KVs are not re-written in place, so they are not seen by
   the changefeed until the schema change becomes "visible". When the schema
   change becomes visible, the changefeed stops to emit all the backfill rows
   before continuing.

Informs: #106906
Epic: None
Release note: None

Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Marius Posta <[email protected]>
Co-authored-by: Jayant Shrivastava <[email protected]>
@postamar postamar mentioned this issue Jul 19, 2023
Closed
@craig craig bot closed this as completed in cd13eb4 Jul 20, 2023
@postamar postamar mentioned this issue Jul 21, 2023
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Jul 21, 2023
scbuild: fix concurrent schema change verification bug.
76d487a 
Previously, we didn't check for concurrent schema changes on targets set
on elements that the builder state didn't know about yet. This patch
fixes this oversight. This regression was recently introduced by cockroachdb#106175.

Fixes: cockroachdb#106487

Release note: None
@postamar postamar mentioned this issue Jul 21, 2023
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Jul 21, 2023
scbuild: fix concurrent schema change verification bug.
7a8bcff 
Previously, we didn't check for concurrent schema changes on targets set
on elements that the builder state didn't know about yet. This patch
fixes this oversight. This regression was recently introduced by cockroachdb#106175.

Fixes: cockroachdb#106487

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

scbuild: fix concurrent schema change verification bug postamar/cockroach
3 participants
@postamar @cockroach-teamcity @renatolabs