Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvcoord/(mux)rangefeed: when changefeed job is cancelled distsender.rangefeed.catchup_ranges doesn't go down #106252

Closed
aliher1911 opened this issue Jul 6, 2023 · 1 comment · Fixed by #107384
Closed

kvcoord/(mux)rangefeed: when changefeed job is cancelled distsender.rangefeed.catchup_ranges doesn't go down #106252

aliher1911 opened this issue Jul 6, 2023 · 1 comment · Fixed by #107384
Assignees
@erikgrinaker
Labels
A-kv-rangefeed Rangefeed infrastructure, server+client C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@aliher1911
Copy link
Contributor

aliher1911 commented Jul 6, 2023 •
edited by exalate-issue-sync bot
Loading

If changefeed jobs are cancelled or paused while catch up scan is running, metric for those ranges won't be decreased.

Problem is similar to #106152

Environment:

  • CockroachDB version 23.1.4 and likely earlier ones

Jira issue: CRDB-29462

Epic CRDB-26372
@aliher1911 aliher1911 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-replication Relating to Raft, consensus, and coordination. labels Jul 6, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 6, 2023

cc @cockroachdb/replication

@erikgrinaker erikgrinaker added A-kv-rangefeed Rangefeed infrastructure, server+client and removed A-kv-replication Relating to Raft, consensus, and coordination. labels Jul 18, 2023
@aliher1911 aliher1911 changed the title kvcoord/(mux)rangefeed: when changefeed job is cancelled distsender.rangefeed. doesn't go down kvcoord/(mux)rangefeed: when changefeed job is cancelled distsender.rangefeed.catchup_ranges doesn't go down Jul 20, 2023
@miretskiy miretskiy mentioned this issue Jul 21, 2023
Merged
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jul 21, 2023
kvcoord: Fix metrics tracking in mux rangefeed
bf6cd30 
Fix an observability bug in mux rangefeed which would
incorrectly count various rangefeed related metrics
(total ranges, catchup ranges, etc).

Fixes cockroachdb#106152
Fixes cockroachdb#106252

Release note: None
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jul 31, 2023
kvcoord: Fix metrics tracking in mux rangefeed
2b12c93 
Fix an observability bug in mux rangefeed which would
incorrectly count various rangefeed related metrics
(total ranges, catchup ranges, etc).

Fixes cockroachdb#106152
Fixes cockroachdb#106252

Release note: None
craig bot pushed a commit that referenced this issue Aug 2, 2023
@rharding6373 @chengxiong-ruan
Merge #104553 #107384 #107996
05ad3c4 
104553: sql: support foreign key checks in udfs r=rharding6373 a=rharding6373

This change removes restrictions around and adds support for running postquery checks in routines, which allows postquery checks like foreign key constraint checks in UDFs.

Epic: CRDB-25388
Informs: #87289

Release note: None

107384: kvcoord: Fix metrics tracking in mux rangefeed r=miretskiy a=miretskiy

Fix an observability bug in mux rangefeed which would incorrectly count various rangefeed related metrics (total ranges, catchup ranges, etc).

Fixes #106152
Fixes #106252

Release note: None

107996: sql: delete TestSchemaChangeCompletion r=chengxiong-ruan a=chengxiong-ruan

Informs: #51796

The test is very buggy and not doing what it was supposed to test. Deleting since we already have TestLegacySchemaChangerWaitsForOtherSchemaChanges and TestConcurrentSchemaChangesDoNotDeadlock.

Release note: None

Co-authored-by: rharding6373 <[email protected]>
Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Co-authored-by: Chengxiong Ruan <[email protected]>
@craig craig bot closed this as completed in 41049cb Aug 2, 2023
@miretskiy miretskiy mentioned this issue Aug 2, 2023
Merged
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Aug 3, 2023
kvcoord: Fix metrics tracking in mux rangefeed
60dc414 
Fix an observability bug in mux rangefeed which would
incorrectly count various rangefeed related metrics
(total ranges, catchup ranges, etc).

Fixes cockroachdb#106152
Fixes cockroachdb#106252

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-rangefeed Rangefeed infrastructure, server+client C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvcoord: Fix metrics tracking in mux rangefeed miretskiy/cockroach
3 participants
@erikgrinaker @aliher1911 @miretskiy