kvserver: phase out useReproposalsV2 #105625
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
tbg
added
C-enhancement
|
cc @cockroachdb/replication |
craig bot
pushed a commit
that referenced
this issue
Jun 27, 2023
97779: kvserver: avoid reusing proposal in tryReproposeWithNewLeaseIndex r=erikgrinaker a=tbg The previous reproposal mechanism is quite complex. We can side-step a good amount of the complexity by not re-using proposals. Instead, when the entry associated to a local proposal gets rejected by the `LeaseAppliedIndex`, we mint a "new" proposal (identical to the old but with a new command ID) which is now responsible for notifying the caller. This is introduced piecemeal, and the "old way" is preserved for continued metamorphic testing (and a guaranteed way to be able to fall back, should we see fallout over the next couple of weeks). Phasing out the gating var `useReproposalsV2` is tracked separately[^1]. [^1]: #105625 Epic: CRDB-25287 Release note: None Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is introduced in #97779 to keep both the old and new way of reproposing with a new lease applied index around.
In a few weeks, we should remove the old way, i.e. hard-code
useReproposalsV2totrueand simplify code based on that.Epic: CRDB-25287
Jira issue: CRDB-29130
The text was updated successfully, but these errors were encountered: