Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: users without system.table_statistics privileges cannot view database table page #105292

Closed
THardy98 opened this issue Jun 21, 2023 · 2 comments
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@THardy98
Copy link

THardy98 commented Jun 21, 2023

Describe the problem

Currently, users without system.table_statistics SELECT privilege cannot use the database table page as the query error causes the entire page to render a fallback error component.

The page should be able to render as normally, displaying the table statistics as unavailable

Jira issue: CRDB-28966

@THardy98 THardy98 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-observability labels Jun 21, 2023
@THardy98 THardy98 self-assigned this Jun 21, 2023
@rafiss
Copy link
Collaborator

rafiss commented Sep 16, 2023

Note that v23.1.11 will have a VIEWSYSTEMTABLE system privilege.

If you do GRANT SYSTEM VIEWSYSTEMTABLE TO user, that user will have the SELECT privilege on all system tables.

@THardy98
Copy link
Author

Below are PRs that allow users with restricted permissions to still view the databases pages:

Databases Page Improvement: #109245
Database Detail Page Improvement: #109432
Table Detail Page Improvement (database table page - specifically relevant to this issue): #109521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

2 participants