Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: expose an API to label (cluster) VMs with name of executing test #104366

Closed
srosenberg opened this issue Jun 5, 2023 · 3 comments
Closed
Assignees
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@srosenberg
Copy link
Member

srosenberg commented Jun 5, 2023

For observability purposes, we need to map a test to the cluster where it was executed. Roachprod already supports custom VM labels across all cloud providers. Hence, it should be straightforward to expose an internal API, that's accessible to roachtest.
Note that a cluster may be reused, hence care should be taken to ensure the label is removed upon test completion.
Prometheus config. should be updated to scrape the new label.

In addition to making it easy to pull up the metrics for a given test run in Grafana, this would also support fine-grained billing attribution (by test name).

Informs: #98658

Jira issue: CRDB-28489

@srosenberg srosenberg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-testeng TestEng Team labels Jun 5, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 5, 2023

cc @cockroachdb/test-eng

srosenberg added a commit to srosenberg/cockroach that referenced this issue Jun 6, 2023
@tbg
Copy link
Member

tbg commented Jul 3, 2023

Came here for +1. I'd like to know what ran on teamcity-10706494-1687931234-31-n3cpu8 on 7/28 3pm and I can find out by going through roachtest nightlies but it's tedious. (I'm not asking anyone to do it for me, just giving an example of the workflow Stan no doubt had in mind when he filed this).

@renatolabs
Copy link
Contributor

@smg260 #107965 should have closed this one, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants