storage: expose timeseries for count of ingestions #103744
Assignees
Labels
A-storage
Relating to our storage engine (Pebble) on-disk storage.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
E-quick-win
Likely to be a quick win for someone experienced.
T-storage
Storage Team
Comments
jbowens
added
A-storage
This comment was marked as resolved.
This comment was marked as resolved.
jbowens
added
the
C-enhancement
raggar
added a commit
to raggar/cockroach
that referenced
this issue
May 25, 2023
Exposed a new metric display the total number of successful ingestion operations performed. Fixes: cockroachdb#103744 Release note: None
This was referenced May 25, 2023
raggar
added a commit
to raggar/cockroach
that referenced
this issue
May 30, 2023
f235f568 Related to: cockroachdb#103744 ac69476c db: avoid logging to stdout in unit tests a40f14d1 db: annotate table number when tables cannot be loaded e7aa90f2 sharedcache: move to a dedicated package bb4fc952 db: deflake additional TestCompactionTombstones cases 4ca2bec5 sharedcache: improved randomized test, fix bugs 5a007460 *: Implement iterators and seqnum substitution for foreign SSTs 45069a0f db: consider scheduling compaction when adding point tombstone compensation 2ff7efbd db: remove experimental point tombstone weight option a8d7345e sharedcache: implement a randomized test cf66a4c9 sharedcache: fix two bugs, add assertions & test case ed934f88 vfs: add logging for OpenReadWrite & WriteAt 25a8e9bb db: add DeleteSized and corresponding compaction heuristics 49ae5454 db: fix leak for compaction bytes-in-progress metric f72555ca tool: improve `wal dump` output 7a5a70ca vfs: make in-mem vfs satisfy the vfs contract 229d8ca9 secondarycache: implement a minimal functional secondary cache cc71ef1d secondarycache: implement a minimal skeleton e44902ba vfs: support WriteAt e892f45b objstorage: implement read-ahead for shared objects 4151e559 objstorage: rename MaxReadahead to SetupForCompaction f6eaf9a6 sstable: don't rely on Stats.NumEntries for virtual sstable creation 5db2191d sstable: clean up suffix rewriter comment, test Release note:
raggar
added a commit
to raggar/cockroach
that referenced
this issue
May 31, 2023
f235f568 Related to: cockroachdb#103744 ac69476c db: avoid logging to stdout in unit tests a40f14d1 db: annotate table number when tables cannot be loaded e7aa90f2 sharedcache: move to a dedicated package bb4fc952 db: deflake additional TestCompactionTombstones cases 4ca2bec5 sharedcache: improved randomized test, fix bugs 5a007460 *: Implement iterators and seqnum substitution for foreign SSTs 45069a0f db: consider scheduling compaction when adding point tombstone compensation 2ff7efbd db: remove experimental point tombstone weight option a8d7345e sharedcache: implement a randomized test cf66a4c9 sharedcache: fix two bugs, add assertions & test case ed934f88 vfs: add logging for OpenReadWrite & WriteAt 25a8e9bb db: add DeleteSized and corresponding compaction heuristics 49ae5454 db: fix leak for compaction bytes-in-progress metric f72555ca tool: improve `wal dump` output 7a5a70ca vfs: make in-mem vfs satisfy the vfs contract 229d8ca9 secondarycache: implement a minimal functional secondary cache cc71ef1d secondarycache: implement a minimal skeleton e44902ba vfs: support WriteAt e892f45b objstorage: implement read-ahead for shared objects 4151e559 objstorage: rename MaxReadahead to SetupForCompaction f6eaf9a6 sstable: don't rely on Stats.NumEntries for virtual sstable creation 5db2191d sstable: clean up suffix rewriter comment, test Release note: None
craig bot
pushed a commit
that referenced
this issue
May 31, 2023
104087: go.mod: bump Pebble to f235f568816e r=RahulAggarwal1016 a=RahulAggarwal1016 ``` f235f568 Related to: #103744 ac69476c db: avoid logging to stdout in unit tests a40f14d1 db: annotate table number when tables cannot be loaded e7aa90f2 sharedcache: move to a dedicated package bb4fc952 db: deflake additional TestCompactionTombstones cases 4ca2bec5 sharedcache: improved randomized test, fix bugs 5a007460 *: Implement iterators and seqnum substitution for foreign SSTs 45069a0f db: consider scheduling compaction when adding point tombstone compensation 2ff7efbd db: remove experimental point tombstone weight option a8d7345e sharedcache: implement a randomized test cf66a4c9 sharedcache: fix two bugs, add assertions & test case ed934f88 vfs: add logging for OpenReadWrite & WriteAt 25a8e9bb db: add DeleteSized and corresponding compaction heuristics 49ae5454 db: fix leak for compaction bytes-in-progress metric f72555ca tool: improve `wal dump` output 7a5a70ca vfs: make in-mem vfs satisfy the vfs contract 229d8ca9 secondarycache: implement a minimal functional secondary cache cc71ef1d secondarycache: implement a minimal skeleton e44902ba vfs: support WriteAt e892f45b objstorage: implement read-ahead for shared objects 4151e559 objstorage: rename MaxReadahead to SetupForCompaction f6eaf9a6 sstable: don't rely on Stats.NumEntries for virtual sstable creation 5db2191d sstable: clean up suffix rewriter comment, test ``` Release note: none Epic: none Co-authored-by: Rahul Aggarwal <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Jun 1, 2023
103914: Expose Ingestions Count Metric r=RahulAggarwal1016 a=RahulAggarwal1016 Fixes: #103744 This change exposes the `Ingest.Count` metric from Pebble to the Cockroach side. Related PR (Pebble Changes): cockroachdb/pebble#2568 Release note: None 104104: cli: fix bug in missing-flag warning r=knz a=miraradeva When the server starts, the user is supposed to see a warning if neither `--listen-addr` nor `--advertise-addr` flags are specified. Currently, even if `--advertise-addr` is specified, the warning is displayed. This patch fixes the small bug causing this behavior. Fixes: #103897 Epic: CRDB-28249 Release note (bug fix): Warning message for missing `--advertise-addr` flag is no longer displayed when the flag is specified upon server start. Co-authored-by: Rahul Aggarwal <[email protected]> Co-authored-by: Mira Radeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have volume of bytes ingested, plus both count and bytes ingested through flushable ingests but no count of all ingestions.
Jira issue: CRDB-28168
The text was updated successfully, but these errors were encountered: