-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
: TestStoreRangeDownReplicate failed under stress #10306
Comments
@petermattis Here's the section where things go batty:
What does this line mean:
|
I'm not familiar with that warning, but looking at the code it seems to be saying that the node received a request that had start and end keys that are not contained in a single range. Perhaps the range recently split. |
Yeah, that message means the range recently split. We should probably just remove this log line (it comes before we return an error that will be handled transparently by DistSender, so it's innocuous). However, the keys used in this message are suspicious. What's trying to operate on a batch that spans from the beginning of the user keyspace to the non-existent key |
I'm seeing the read in this test take like more than a second every once in a while which might explain why the test is failing. If you reduce the timeout in the test to 1 second and time the Get() within the test I've seen it take 2 seconds. I suspect that this might have to do with range quiescence and therefore assigning to peter. |
I can't reproduce a failure here. Can you provide details on what commands you're running? |
run
|
Previously we were releasing the snapshot (i.e. calling `Replica.CloseOutSnap()`) when the ChangeReplicas operation completed. Now we release the snapshot as soon as the remote node has applied it. This is important to allow other ranges to make progress which might be required for the current ChangeReplicas operation to complete. Fixes cockroachdb#10483 Fixes cockroachdb#10306 See cockroachdb#10409
SHA: https://github.com/cockroachdb/cockroach/commits/539acaedf458b09a5246992d9d05561231ecca4e
Stress build found a failed test:
The text was updated successfully, but these errors were encountered: